Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: chrome/browser/views/bookmark_editor_view_unittest.cc

Issue 3176024: Convert wstrings in bookmarks, part 4. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop.h" 5 #include "base/message_loop.h"
6 #include "base/string_util.h" 6 #include "base/string_util.h"
7 #include "chrome/browser/bookmarks/bookmark_model.h" 7 #include "chrome/browser/bookmarks/bookmark_model.h"
8 #include "chrome/browser/chrome_thread.h" 8 #include "chrome/browser/chrome_thread.h"
9 #include "chrome/browser/pref_service.h" 9 #include "chrome/browser/pref_service.h"
10 #include "chrome/browser/profile.h" 10 #include "chrome/browser/profile.h"
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 ASSERT_EQ(2, other_node->GetChildCount()); 302 ASSERT_EQ(2, other_node->GetChildCount());
303 303
304 const BookmarkNode* new_node = other_node->GetChild(0); 304 const BookmarkNode* new_node = other_node->GetChild(0);
305 305
306 EXPECT_EQ(ASCIIToUTF16("new_a"), new_node->GetTitleAsString16()); 306 EXPECT_EQ(ASCIIToUTF16("new_a"), new_node->GetTitleAsString16());
307 } 307 }
308 308
309 // Creates a new folder. 309 // Creates a new folder.
310 TEST_F(BookmarkEditorViewTest, NewFolder) { 310 TEST_F(BookmarkEditorViewTest, NewFolder) {
311 BookmarkEditor::EditDetails details; 311 BookmarkEditor::EditDetails details;
312 details.urls.push_back(std::make_pair(GURL(base_path() + "x"), L"z")); 312 details.urls.push_back(std::make_pair(GURL(base_path() + "x"),
313 ASCIIToUTF16("z")));
313 details.type = BookmarkEditor::EditDetails::NEW_FOLDER; 314 details.type = BookmarkEditor::EditDetails::NEW_FOLDER;
314 CreateEditor(profile_.get(), model_->GetBookmarkBarNode(), 315 CreateEditor(profile_.get(), model_->GetBookmarkBarNode(),
315 details, BookmarkEditorView::SHOW_TREE); 316 details, BookmarkEditorView::SHOW_TREE);
316 317
317 // The url field shouldn't be visible. 318 // The url field shouldn't be visible.
318 EXPECT_FALSE(URLTFHasParent()); 319 EXPECT_FALSE(URLTFHasParent());
319 SetTitleText(L"new_F"); 320 SetTitleText(L"new_F");
320 321
321 ApplyEdits(editor_tree_model()->GetRoot()->GetChild(0)); 322 ApplyEdits(editor_tree_model()->GetRoot()->GetChild(0));
322 323
323 // Make sure the folder was created. 324 // Make sure the folder was created.
324 ASSERT_EQ(4, model_->GetBookmarkBarNode()->GetChildCount()); 325 ASSERT_EQ(4, model_->GetBookmarkBarNode()->GetChildCount());
325 const BookmarkNode* new_node = 326 const BookmarkNode* new_node =
326 model_->GetBookmarkBarNode()->GetChild(3); 327 model_->GetBookmarkBarNode()->GetChild(3);
327 EXPECT_EQ(BookmarkNode::FOLDER, new_node->type()); 328 EXPECT_EQ(BookmarkNode::FOLDER, new_node->type());
328 EXPECT_EQ(ASCIIToUTF16("new_F"), new_node->GetTitleAsString16()); 329 EXPECT_EQ(ASCIIToUTF16("new_F"), new_node->GetTitleAsString16());
329 // The node should have one child. 330 // The node should have one child.
330 ASSERT_EQ(1, new_node->GetChildCount()); 331 ASSERT_EQ(1, new_node->GetChildCount());
331 const BookmarkNode* new_child = new_node->GetChild(0); 332 const BookmarkNode* new_child = new_node->GetChild(0);
332 // Make sure the child url/title match. 333 // Make sure the child url/title match.
333 EXPECT_EQ(BookmarkNode::URL, new_child->type()); 334 EXPECT_EQ(BookmarkNode::URL, new_child->type());
334 EXPECT_EQ(details.urls[0].second, new_child->GetTitle()); 335 EXPECT_EQ(details.urls[0].second, new_child->GetTitle());
335 EXPECT_TRUE(details.urls[0].first == new_child->GetURL()); 336 EXPECT_TRUE(details.urls[0].first == new_child->GetURL());
336 } 337 }
337 338
338 // Creates a new folder and selects a different folder for the folder to appear 339 // Creates a new folder and selects a different folder for the folder to appear
339 // in then the editor is initially created showing. 340 // in then the editor is initially created showing.
340 TEST_F(BookmarkEditorViewTest, MoveFolder) { 341 TEST_F(BookmarkEditorViewTest, MoveFolder) {
341 BookmarkEditor::EditDetails details; 342 BookmarkEditor::EditDetails details;
342 details.urls.push_back(std::make_pair(GURL(base_path() + "x"), L"z")); 343 details.urls.push_back(std::make_pair(GURL(base_path() + "x"),
344 ASCIIToUTF16("z")));
343 details.type = BookmarkEditor::EditDetails::NEW_FOLDER; 345 details.type = BookmarkEditor::EditDetails::NEW_FOLDER;
344 CreateEditor(profile_.get(), model_->GetBookmarkBarNode(), 346 CreateEditor(profile_.get(), model_->GetBookmarkBarNode(),
345 details, BookmarkEditorView::SHOW_TREE); 347 details, BookmarkEditorView::SHOW_TREE);
346 348
347 SetTitleText(L"new_F"); 349 SetTitleText(L"new_F");
348 350
349 // Create the folder in the 'other' folder. 351 // Create the folder in the 'other' folder.
350 ApplyEdits(editor_tree_model()->GetRoot()->GetChild(1)); 352 ApplyEdits(editor_tree_model()->GetRoot()->GetChild(1));
351 353
352 // Make sure the folder we edited is still there. 354 // Make sure the folder we edited is still there.
353 ASSERT_EQ(3, model_->other_node()->GetChildCount()); 355 ASSERT_EQ(3, model_->other_node()->GetChildCount());
354 const BookmarkNode* new_node = model_->other_node()->GetChild(2); 356 const BookmarkNode* new_node = model_->other_node()->GetChild(2);
355 EXPECT_EQ(BookmarkNode::FOLDER, new_node->type()); 357 EXPECT_EQ(BookmarkNode::FOLDER, new_node->type());
356 EXPECT_EQ(ASCIIToUTF16("new_F"), new_node->GetTitleAsString16()); 358 EXPECT_EQ(ASCIIToUTF16("new_F"), new_node->GetTitleAsString16());
357 // The node should have one child. 359 // The node should have one child.
358 ASSERT_EQ(1, new_node->GetChildCount()); 360 ASSERT_EQ(1, new_node->GetChildCount());
359 const BookmarkNode* new_child = new_node->GetChild(0); 361 const BookmarkNode* new_child = new_node->GetChild(0);
360 // Make sure the child url/title match. 362 // Make sure the child url/title match.
361 EXPECT_EQ(BookmarkNode::URL, new_child->type()); 363 EXPECT_EQ(BookmarkNode::URL, new_child->type());
362 EXPECT_EQ(details.urls[0].second, new_child->GetTitle()); 364 EXPECT_EQ(details.urls[0].second, new_child->GetTitle());
363 EXPECT_TRUE(details.urls[0].first == new_child->GetURL()); 365 EXPECT_TRUE(details.urls[0].first == new_child->GetURL());
364 } 366 }
OLDNEW
« no previous file with comments | « chrome/browser/browser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698