chrome/browser/cocoa/location_bar/location_bar_view_mac.mm - Issue 3176021: Ensure that a browser action is never passed to a function which expects a page action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

Issue 3176021: Ensure that a browser action is never passed to a function which expects a page action. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Better fix: don't pass a browser action into a function expecting a page action. Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

diff --git a/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

index fd1acb9bc9934ed5b5ba71c5c151d966dcd4a7b8..28f524b8f938b3d5b2fd028f1e2e29d228642f0f 100644

--- a/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

+++ b/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

@@ -287,6 +287,8 @@ PageActionDecoration* LocationBarViewMac::GetPageActionDecoration(

if (page_action_decorations_[i]->page_action() == page_action)

return page_action_decorations_[i];

}

+ // If |page_action| is the browser action of an extension, no element in

+ // |page_action_decorations_| will match.

NOTREACHED();

return NULL;

}

« no previous file with comments | « chrome/browser/cocoa/location_bar/location_bar_view_mac.h ('k') | no next file » | no next file with comments »