Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 3176001: Merge 65095 - Removing an element from an anonymous block causes crash... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/WebKit/472/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 55630)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,28 @@
+2010-08-10 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Removing an element from an anonymous block causes crash
+ https://bugs.webkit.org/show_bug.cgi?id=42309
+
+ There was a case where a continuation was added as a child, but if you asked
+ that child who is your parent, it would return the wrong answer.
+
+ The specific scenario was when a sibling of an element who was the start of a
+ continuation was present. Retrieving the parent object had then follow the sibling
+ chain and then follow the originating continuation chain.
+
+ Test: accessibility/removed-anonymous-block-child-causes-crash.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::nextSibling):
+ Fix erroneous comment
+ (WebCore::nextContinuation):
+ (WebCore::AccessibilityRenderObject::renderParentObject):
+ Handle unhandled continuation case.
+ (WebCore::AccessibilityRenderObject::addChildren):
+ ASSERT that the parentObject() is the same when adding a new child.
+
2010-07-30 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by David Levin.

Powered by Google App Engine
This is Rietveld 408576698