Add mouse event support to Chromoting client (Pepper and X11).

Add mouse event support to Chromoting client (Pepper and X11).

BUG=none
TEST=remoting unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57598

[Alpha Left Google, 2010-08-20 05:30:32]

http://codereview.chromium.org/3175028/diff/2001/3002
File remoting/client/host_connection.h (right):

http://codereview.chromium.org/3175028/diff/2001/3002#newcode47
remoting/client/host_connection.h:47: virtual void SendEvent(const
ChromotingClientMessage& msg) = 0;
Call this SendMessage?

http://codereview.chromium.org/3175028/diff/2001/3005
File remoting/client/jingle_host_connection.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3005#newcode45
remoting/client/jingle_host_connection.cc:45: if (jingle_channel_ == NULL) {
nit: if (!jingle_channel_)

http://codereview.chromium.org/3175028/diff/2001/3008
File remoting/client/plugin/pepper_input_handler.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3008#newcode22
remoting/client/plugin/pepper_input_handler.cc:22:
SendMouseMoveEvent(static_cast<int>(event.x),
Is this a relative position or absolute position?

http://codereview.chromium.org/3175028/diff/2001/3009
File remoting/client/plugin/pepper_input_handler.h (right):

http://codereview.chromium.org/3175028/diff/2001/3009#newcode9
remoting/client/plugin/pepper_input_handler.h:9: 
removing this empty line?

http://codereview.chromium.org/3175028/diff/2001/3010
File remoting/client/x11_input_handler.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3010#newcode77
remoting/client/x11_input_handler.cc:77: SendMouseMoveEvent(x, y);
Is this the right thread to send the message?

http://codereview.chromium.org/3175028/diff/2001/3010#newcode81
remoting/client/x11_input_handler.cc:81: MouseButton button =
MouseButtonUndefined;
Same here. Is this the right thread?

http://codereview.chromium.org/3175028/diff/2001/3012
File remoting/client/x11_view.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3012#newcode61
remoting/client/x11_view.cc:61: ExposureMask
nit: Try to squeeze the flags in 2 lines?

[garykac, 2010-08-25 22:33:30]

http://codereview.chromium.org/3175028/diff/2001/3002
File remoting/client/host_connection.h (right):

http://codereview.chromium.org/3175028/diff/2001/3002#newcode47
remoting/client/host_connection.h:47: virtual void SendEvent(const
ChromotingClientMessage& msg) = 0;
On 2010/08/20 05:30:32, Alpha wrote:
> Call this SendMessage?
> 

Sounds good. Done.

http://codereview.chromium.org/3175028/diff/2001/3005
File remoting/client/jingle_host_connection.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3005#newcode45
remoting/client/jingle_host_connection.cc:45: if (jingle_channel_ == NULL) {
On 2010/08/20 05:30:32, Alpha wrote:
> nit: if (!jingle_channel_)

Done.

http://codereview.chromium.org/3175028/diff/2001/3008
File remoting/client/plugin/pepper_input_handler.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3008#newcode22
remoting/client/plugin/pepper_input_handler.cc:22:
SendMouseMoveEvent(static_cast<int>(event.x),
On 2010/08/20 05:30:32, Alpha wrote:
> Is this a relative position or absolute position?

These are always absolute. SendMouseMoveEvent switches between relative/absolute
as appropriate.

http://codereview.chromium.org/3175028/diff/2001/3009
File remoting/client/plugin/pepper_input_handler.h (right):

http://codereview.chromium.org/3175028/diff/2001/3009#newcode9
remoting/client/plugin/pepper_input_handler.h:9: 
On 2010/08/20 05:30:32, Alpha wrote:
> removing this empty line?

Done.

http://codereview.chromium.org/3175028/diff/2001/3010
File remoting/client/x11_input_handler.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3010#newcode77
remoting/client/x11_input_handler.cc:77: SendMouseMoveEvent(x, y);
On 2010/08/20 05:30:32, Alpha wrote:
> Is this the right thread to send the message?

Added DCHECKs to verify the correct thread.

http://codereview.chromium.org/3175028/diff/2001/3010#newcode81
remoting/client/x11_input_handler.cc:81: MouseButton button =
MouseButtonUndefined;
On 2010/08/20 05:30:32, Alpha wrote:
> Same here. Is this the right thread?

see above

http://codereview.chromium.org/3175028/diff/2001/3012
File remoting/client/x11_view.cc (right):

http://codereview.chromium.org/3175028/diff/2001/3012#newcode61
remoting/client/x11_view.cc:61: ExposureMask
On 2010/08/20 05:30:32, Alpha wrote:
> nit: Try to squeeze the flags in 2 lines?

Done.

[Alpha Left Google, 2010-08-26 17:45:37]

LGTM.