Issue 3175004: Chrome autotest build speedup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3175004: Chrome autotest build speedup (Closed)

Created:
10 years, 4 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
davidjames

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://gitrw.chromium.org/autotest.git

Visibility:
Public.

Description

Chrome autotest build speedup BUG=chromium-os:5691 TEST=make sure chrome builds are speedy again

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	client/deps/chrome_test/chrome_test.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

davidjames

10 years, 4 months ago (2010-08-11 21:09:57 UTC) #2

LGTM w/nit

http://codereview.chromium.org/3175004/diff/1/2
File client/deps/chrome_test/chrome_test.py (right):

http://codereview.chromium.org/3175004/diff/1/2#newcode24
client/deps/chrome_test/chrome_test.py:24: utils.run('cp -ral %s %s' %
(chrome_test_files, testsrc_dir))
From the docs for cp, -a is the "same as -dpR". So the -r here is not needed,
but -a and -l are needed.

Expand Messages | Collapse Messages