Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 3175003: Change chronos password rather than root. (Closed)

Created:
10 years, 4 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
gauravsh, djmm
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson, Sumit, bdavirro
Visibility:
Public.

Description

Change chronos password rather than root. Also, rename the script to reflect its specific purpose. BUG=5580 TEST=ran on an image, installed and tested with new password

Patch Set 1 #

Patch Set 2 : Rename script to set_chronos_password.sh #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
A + scripts/image_signing/set_chronos_password.sh View 2 chunks +10 lines, -14 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
petkov
10 years, 4 months ago (2010-08-11 16:33:59 UTC) #1
petkov
Also, renamed the script to set_chronos_password.sh. Other image customization can be added in separate scripts.
10 years, 4 months ago (2010-08-11 16:45:29 UTC) #2
petkov
10 years, 4 months ago (2010-08-11 16:46:48 UTC) #3
gauravsh
Lgtm On Aug 11, 2010 12:46 PM, <petkov@chromium.org> wrote: > http://codereview.chromium.org/3175003/show
10 years, 4 months ago (2010-08-11 16:51:33 UTC) #4
djmm
http://codereview.chromium.org/3175003/diff/3001/4001 File scripts/image_signing/set_chronos_password.sh (right): http://codereview.chromium.org/3175003/diff/3001/4001#newcode9 scripts/image_signing/set_chronos_password.sh:9: # Usage: ./set_chronos_password.sh <image.bin> <chronos_password> A standard I've been ...
10 years, 4 months ago (2010-08-11 17:35:47 UTC) #5
petkov
10 years, 4 months ago (2010-08-11 18:07:27 UTC) #6
http://codereview.chromium.org/3175003/diff/3001/4001
File scripts/image_signing/set_chronos_password.sh (right):

http://codereview.chromium.org/3175003/diff/3001/4001#newcode9
scripts/image_signing/set_chronos_password.sh:9: # Usage:
./set_chronos_password.sh <image.bin> <chronos_password>
On 2010/08/11 17:35:47, djmm wrote:
> A standard I've been pushing in scripts is to set
> PROG=$(basename $0) at the top of the script so you can refer to it here with
> $PROG and never have to change it again.

Done in http://codereview.chromium.org/3164006/show

Powered by Google App Engine
This is Rietveld 408576698