Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 3174032: Tweak preference code to work with or without the 'managed' property, makes f... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/pref_ui.js
===================================================================
--- chrome/browser/resources/options/pref_ui.js (revision 57118)
+++ chrome/browser/resources/options/pref_ui.js (working copy)
@@ -25,9 +25,11 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.managed = event.value['managed']
+ self.checked = event.value['value'] ? event.value['value']
+ : event.value;
+ self.managed = event.value['managed'] ? event.value['managed']
+ : false;
self.disabled = self.managed;
- self.checked = event.value['value'];
});
// Listen to user events.
@@ -64,9 +66,12 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.managed = event.value['managed']
+ var value = event.value['value'] ? event.value['value']
+ : event.value;
+ self.managed = event.value['managed'] ? event.value['managed']
+ : false;
+ self.checked = String(value) == self.value;
self.disabled = self.managed;
- self.checked = String(event.value['value']) == self.value;
});
// Listen to user events.
@@ -116,9 +121,11 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.managed = event.value['managed']
+ self.value = event.value['value'] ? event.value['value']
+ : event.value;
+ self.managed = event.value['managed'] ? event.value['managed']
+ : false;
self.disabled = self.managed;
- self.value = event.value['value'];
});
// Listen to user events.
@@ -191,10 +198,13 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.managed = event.value['managed']
+ var value = event.value['value'] ? event.value['value']
+ : event.value;
+ self.managed = event.value['managed'] ? event.value['managed']
+ : false;
self.disabled = self.managed;
for (var i = 0; i < self.options.length; i++) {
- if (self.options[i].value == event.value['value']) {
+ if (self.options[i].value == value) {
self.selectedIndex = i;
return;
}
@@ -274,9 +284,11 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.managed = event.value['managed']
+ self.value = event.value['value'] ? event.value['value']
+ : event.value;
+ self.managed = event.value['managed'] ? event.value['managed']
+ : false;
self.disabled = self.managed;
- self.value = event.value['value'];
});
// Listen to user events.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698