Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/browser/tab_contents/tab_contents_delegate.h

Issue 3174030: Making window.focus()/blur() work only when there is a user gesture. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/browser/tab_contents/tab_contents_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents_delegate.h
diff --git a/chrome/browser/tab_contents/tab_contents_delegate.h b/chrome/browser/tab_contents/tab_contents_delegate.h
index 2a3150860c78109d3b69733f86932f1190e73066..921c9a720580f9297e9774b15f67816cf75e17d9 100644
--- a/chrome/browser/tab_contents/tab_contents_delegate.h
+++ b/chrome/browser/tab_contents/tab_contents_delegate.h
@@ -68,6 +68,10 @@ class TabContentsDelegate : public AutomationResourceRoutingDelegate {
// Selects the specified contents, bringing its container to the front.
virtual void ActivateContents(TabContents* contents) = 0;
+ // Deactivates the specified contents by deactivating its container and
+ // potentialy moving it to the back of the Z order.
+ virtual void DeactivateContents(TabContents* contents) = 0;
+
// Notifies the delegate that this contents is starting or is done loading
// some resource. The delegate should use this notification to represent
// loading feedback. See TabContents::is_loading()
@@ -179,11 +183,6 @@ class TabContentsDelegate : public AutomationResourceRoutingDelegate {
// this. Returns true if the delegate successfully handled it.
virtual bool TakeFocus(bool reverse);
- // Called by WebKit to notify that the page requested the tab hosting window
- // to be activated/deactivated (by calling window.focus()/blur()).
- virtual void Activate();
- virtual void Deactivate();
-
// Changes the blocked state of the tab at |index|. TabContents are
// considered blocked while displaying a tab modal dialog. During that time
// renderer host will ignore any UI interaction within TabContent outside of
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/browser/tab_contents/tab_contents_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698