Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc

Issue 3174030: Making window.focus()/blur() work only when there is a user gesture. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h" 5 #include "chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h"
6 6
7 #include "chrome/browser/browser.h" 7 #include "chrome/browser/browser.h"
8 #include "chrome/browser/browser_window.h" 8 #include "chrome/browser/browser_window.h"
9 #include "chrome/browser/profile.h" 9 #include "chrome/browser/profile.h"
10 #include "chrome/browser/tab_contents/tab_contents.h" 10 #include "chrome/browser/tab_contents/tab_contents.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 initial_pos, user_gesture); 69 initial_pos, user_gesture);
70 browser->window()->Show(); 70 browser->window()->Show();
71 } 71 }
72 } 72 }
73 73
74 void HtmlDialogTabContentsDelegate::ActivateContents(TabContents* contents) { 74 void HtmlDialogTabContentsDelegate::ActivateContents(TabContents* contents) {
75 // We don't do anything here because there's only one TabContents in 75 // We don't do anything here because there's only one TabContents in
76 // this frame and we don't have a TabStripModel. 76 // this frame and we don't have a TabStripModel.
77 } 77 }
78 78
79 void HtmlDialogTabContentsDelegate::DeactivateContents(TabContents* contents) {
80 // We don't care about this notification (called when a user gesture triggers
81 // a call to window.blur()).
82 }
83
79 void HtmlDialogTabContentsDelegate::LoadingStateChanged(TabContents* source) { 84 void HtmlDialogTabContentsDelegate::LoadingStateChanged(TabContents* source) {
80 // We don't care about this notification. 85 // We don't care about this notification.
81 } 86 }
82 87
83 void HtmlDialogTabContentsDelegate::CloseContents(TabContents* source) { 88 void HtmlDialogTabContentsDelegate::CloseContents(TabContents* source) {
84 // We receive this message but don't handle it because we really do the 89 // We receive this message but don't handle it because we really do the
85 // cleanup somewhere else (namely, HtmlDialogUIDelegate::OnDialogClosed()). 90 // cleanup somewhere else (namely, HtmlDialogUIDelegate::OnDialogClosed()).
86 } 91 }
87 92
88 bool HtmlDialogTabContentsDelegate::IsPopup(const TabContents* source) const { 93 bool HtmlDialogTabContentsDelegate::IsPopup(const TabContents* source) const {
(...skipping 10 matching lines...) Expand all
99 104
100 void HtmlDialogTabContentsDelegate::UpdateTargetURL(TabContents* source, 105 void HtmlDialogTabContentsDelegate::UpdateTargetURL(TabContents* source,
101 const GURL& url) { 106 const GURL& url) {
102 // Ignored. 107 // Ignored.
103 } 108 }
104 109
105 bool HtmlDialogTabContentsDelegate::ShouldAddNavigationToHistory() const { 110 bool HtmlDialogTabContentsDelegate::ShouldAddNavigationToHistory() const {
106 return false; 111 return false;
107 } 112 }
108 113
OLDNEW
« no previous file with comments | « chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h ('k') | chrome/browser/external_tab_container_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698