Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/blocked_popup_container.h

Issue 3174030: Making window.focus()/blur() work only when there is a user gesture. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/browser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Defines the public interface for the blocked popup notifications. This 5 // Defines the public interface for the blocked popup notifications. This
6 // interface should only be used by TabContents. Users and subclasses of 6 // interface should only be used by TabContents. Users and subclasses of
7 // TabContents should use the appropriate methods on TabContents to access 7 // TabContents should use the appropriate methods on TabContents to access
8 // information about blocked popups. 8 // information about blocked popups.
9 9
10 #ifndef CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_ 10 #ifndef CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 virtual void NavigationStateChanged(const TabContents* source, 53 virtual void NavigationStateChanged(const TabContents* source,
54 unsigned changed_flags) {} 54 unsigned changed_flags) {}
55 55
56 // Forwards AddNewContents to our |owner_|. 56 // Forwards AddNewContents to our |owner_|.
57 virtual void AddNewContents(TabContents* source, 57 virtual void AddNewContents(TabContents* source,
58 TabContents* new_contents, 58 TabContents* new_contents,
59 WindowOpenDisposition disposition, 59 WindowOpenDisposition disposition,
60 const gfx::Rect& initial_position, 60 const gfx::Rect& initial_position,
61 bool user_gesture); 61 bool user_gesture);
62 62
63 // Ignore activation requests from the TabContents we're blocking. 63 // Ignore activation/deactivation requests from the TabContents we're
64 // blocking.
64 virtual void ActivateContents(TabContents* contents) {} 65 virtual void ActivateContents(TabContents* contents) {}
66 virtual void DeactivateContents(TabContents* contents) {}
65 67
66 // Ignored; BlockedPopupContainer doesn't display a throbber. 68 // Ignored; BlockedPopupContainer doesn't display a throbber.
67 virtual void LoadingStateChanged(TabContents* source) {} 69 virtual void LoadingStateChanged(TabContents* source) {}
68 70
69 // Removes |source| from our internal list of blocked popups. 71 // Removes |source| from our internal list of blocked popups.
70 virtual void CloseContents(TabContents* source); 72 virtual void CloseContents(TabContents* source);
71 73
72 // Changes the opening rectangle associated with |source|. 74 // Changes the opening rectangle associated with |source|.
73 virtual void MoveContents(TabContents* source, const gfx::Rect& new_bounds); 75 virtual void MoveContents(TabContents* source, const gfx::Rect& new_bounds);
74 76
(...skipping 25 matching lines...) Expand all
100 // The TabContents that owns and constrains this BlockedPopupContainer. 102 // The TabContents that owns and constrains this BlockedPopupContainer.
101 TabContents* owner_; 103 TabContents* owner_;
102 104
103 // Information about all blocked popups. 105 // Information about all blocked popups.
104 BlockedPopups blocked_popups_; 106 BlockedPopups blocked_popups_;
105 107
106 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedPopupContainer); 108 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedPopupContainer);
107 }; 109 };
108 110
109 #endif // CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_ 111 #endif // CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698