Issue 3174028: DOMUI: Implement the base HTML for the 'Edit credit card' AutoFill overlay.

Issue 3174028: DOMUI: Implement the base HTML for the 'Edit credit card' AutoFill overlay. (Closed)

Created:
10 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
dhg, csilv

CC:
chromium-reviews, dhg, ben+cc_chromium.org, arv (Not doing code reviews), dhollowa

Visibility:
Public.

Description

DOMUI: Implement the base HTML for the 'Edit credit card' AutoFill overlay. BUG=49094 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57110

Patch Set 3 : Remove debugging. #

Patch Set 4 : Forgotten files. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -0 lines)			Patch
A	chrome/browser/dom_ui/autofill_edit_creditcard_handler.h	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	chrome/browser/dom_ui/autofill_edit_creditcard_handler.cc	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options_ui.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options.html	View	1	5 chunks	+5 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/options/autofill_edit_creditcard_overlay.css	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/options/autofill_edit_creditcard_overlay.html	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/options/autofill_edit_creditcard_overlay.js	View		1 chunk	+104 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_options.js	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

LGTM after fix below. http://codereview.chromium.org/3174028/diff/3001/4005 File chrome/browser/resources/options/autofill_options.js (right): http://codereview.chromium.org/3174028/diff/3001/4005#newcode43 chrome/browser/resources/options/autofill_options.js:43: OptionsPage.showOverlay('autoFillEditCreditCardOverlay'); looks like you changed ...

10 years, 4 months ago (2010-08-23 20:03:18 UTC) #2

James Hawkins

http://codereview.chromium.org/3174028/diff/3001/4005 File chrome/browser/resources/options/autofill_options.js (right): http://codereview.chromium.org/3174028/diff/3001/4005#newcode43 chrome/browser/resources/options/autofill_options.js:43: OptionsPage.showOverlay('autoFillEditCreditCardOverlay'); On 2010/08/23 20:03:19, csilv wrote: > looks like ...

10 years, 4 months ago (2010-08-23 20:32:48 UTC) #3

James Hawkins

Can you take another look? I forgot to git add the actual html/css/js files for ...

10 years, 4 months ago (2010-08-23 20:53:22 UTC) #4

csilv

10 years, 4 months ago (2010-08-23 21:14:03 UTC) #5

On 2010/08/23 20:53:22, James Hawkins wrote:
> Can you take another look? I forgot to git add the actual html/css/js files
for
> this overlay.

LGTM for added .css/.html/.js

Expand Messages | Collapse Messages