Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: build/common.gypi

Issue 3174026: Linux: Fix Breakpad variables in build/common.gypi. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 56917)
+++ build/common.gypi (working copy)
@@ -91,6 +91,8 @@
# building on.
'target_arch%': '<(host_arch)',
+ # TODO(thestig) remove these after the Linux Reliability bot stops
+ # using them.
# We do want to build Chromium with Breakpad support in certain
# situations. I.e. for Chrome bot.
'linux_chromium_breakpad%': 0,
@@ -247,7 +249,11 @@
# Set this to true to enable SELinux support.
'selinux%': 0,
- # Strip the binary after dumping symbols.
+ # Override whether we should use Breakpad on Linux. I.e. for Chrome bot.
+ 'linux_breakpad%': 0,
+ # And if we want to dump symbols for Breakpad-enabled builds.
+ 'linux_dump_symbols%': 0,
+ # And if we want to strip the binary after dumping symbols.
'linux_strip_binary%': 0,
# Enable TCMalloc.
@@ -300,8 +306,6 @@
'conditions': [
['branding=="Chrome" or linux_chromium_breakpad==1', {
'linux_breakpad%': 1,
- }, {
- 'linux_breakpad%': 0,
}],
# All Chrome builds have breakpad symbols, but only process the
# symbols from official builds.
@@ -311,8 +315,6 @@
'(branding=="Chrome" and buildtype=="Official" and '
'target_arch=="ia32")', {
'linux_dump_symbols%': 1,
- }, {
- 'linux_dump_symbols%': 0,
}],
['toolkit_views==0', {
# GTK wants Title Case strings
@@ -355,7 +357,6 @@
['component=="shared_library"', {
'win_use_allocator_shim%': 0,
}],
-
['MSVS_VERSION=="2005"', {
'msvs_multi_core_compile%': 0,
},{
@@ -1274,7 +1275,6 @@
],
}],
],
-
'msvs_system_include_dirs': [
'<(DEPTH)/third_party/platformsdk_win7/files/Include',
'<(DEPTH)/third_party/directxsdk/files/Include',
@@ -1295,7 +1295,6 @@
[ 'msvs_multi_core_compile', {
'AdditionalOptions': ['/MP'],
}],
-
['component=="shared_library"', {
'ExceptionHandling': '1', # /EHsc
}, {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698