Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 3174023: Revert 56834 - Fix a few test failures when landing http://trac.webkit.org/ch... (Closed)

Created:
10 years, 4 months ago by Johnny(Jianning) Ding
Modified:
9 years, 7 months ago
Reviewers:
jnd
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 56834 - Fix a few test failures when landing http://trac.webkit.org/changeset/57178. http://trac.webkit.org/changeset/57178 broke some tests in browser_test and ui_test. In the test RedirectTest.ClientCancelled, it needs a user-initiated event to trigger the redirect, now it uses "javaScript:click()". When landing r57178, the call of window.open which is inside the call of javaScript:click() was treated as non user-initiated, so the in-page location change was treated as client redirect and the redirect was recoreded, that is why this test was failed when landing r57178. (Please refer to the logic in FrameLoaderClientImpl::dispatchDidNavigateWithinPage.) In the tests AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension and ExtensionBrowserTest.WindowOpenInvalidExtension, they assume the new tabs opened by window.open in current window. But when landing r57178, since those calls of window.open were treated as non user-initiated, the disposition type of new tabs were changed to Popup, which caused a few new tabs were created instead of a few new tabs in current window (Please refer to RenderView::show), which cause those tests were failed when landing r57178.), that is why those tests were failed when landing r57178. BUG=17655 TEST=RedirectTest.ClientCancelled, AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension, ExtensionBrowserTest.WindowOpenInvalidExtension Review URL: http://codereview.chromium.org/3136019 TBR=jnd@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -53 lines) Patch
M chrome/browser/extensions/app_process_apitest.cc View 5 chunks +14 lines, -22 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/history/redirect_uitest.cc View 4 chunks +2 lines, -25 lines 0 comments Download
M chrome/test/data/cancelled_redirect_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Johnny(Jianning) Ding
10 years, 4 months ago (2010-08-20 11:57:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698