GTTF: Make our handling of Windows pre-processor symbols more consistent.

GTTF: Make our handling of Windows pre-processor symbols more consistent.

For example, there are differences between unit_tests and browser_tests,
which cause ridiculous problems when moving a test between those.

We're using the symbols anyway, so let's centralize it for maintainability.

TEST=compile
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57555

[Paweł Hajdan Jr., 2010-08-25 19:31:11]

ping

[lcamtuf, 2010-08-25 20:28:09]

I'm not exactly sure why I'm on this CL?

[Paweł Hajdan Jr., 2010-08-25 20:30:15]

This potentially affects security. Feel free to remove yourself from
reviewers.

On Wed, Aug 25, 2010 at 13:28, <lcamtuf@gmail.com> wrote:

> I'm not exactly sure why I'm on this CL?
>
>
> http://codereview.chromium.org/3173044/show
>

[lcamtuf, 2010-08-25 20:35:09]

If it just consolidates the list in one place, seems fine by me, but I'm not
familiar with this code at all, so a second look from a competent party would be
good :-)

[cpu_(ooo_6.6-7.5), 2010-08-25 21:09:52]

It seems to me that this CL does not effectively change the preprocessor symbols
so LGTM

If I given project has deprecated sprintf it would not be a good idea to allow
it again.

[Paweł Hajdan Jr., 2010-08-25 21:32:30]

This potentially affects security. Feel free to remove yourself from
reviewers.

On Wed, Aug 25, 2010 at 13:28, <lcamtuf@gmail.com> wrote:

> I'm not exactly sure why I'm on this CL?
>
>
> http://codereview.chromium.org/3173044/show
>

[Paweł Hajdan Jr., 2010-08-25 22:05:47]

On 2010/08/25 21:09:52, cpu wrote:
> It seems to me that this CL does not effectively change the preprocessor
symbols
> so LGTM

It does. browser_tests used to not have some of the symbols, which made me break
the build.

> If I given project has deprecated sprintf it would not be a good idea to allow
> it again.

Right. On the other hand, consistency in the build system is also important. I
think that instead of excluding it for single projects, which is prone to
compile errors when modifying code, we should centralize it and then remove all
at once.

[Paweł Hajdan Jr., 2010-08-25 22:14:56]

This potentially affects security. Feel free to remove yourself from
reviewers.

On Wed, Aug 25, 2010 at 13:28, <lcamtuf@gmail.com> wrote:

> I'm not exactly sure why I'm on this CL?
>
>
> http://codereview.chromium.org/3173044/show
>

[Paweł Hajdan Jr., 2010-08-26 04:04:04]

This potentially affects security. Feel free to remove yourself from
reviewers.

On Wed, Aug 25, 2010 at 13:28, <lcamtuf@gmail.com> wrote:

> I'm not exactly sure why I'm on this CL?
>
>
> http://codereview.chromium.org/3173044/show
>

[darin (slow to review), 2010-08-27 03:40:00]

LGTM