Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 3173043: Move theme files in chrome/browser/ into a themes/ subdir. (Closed)

Created:
10 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paul Godavari, Aaron Boodman, pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr., davemoore+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Move theme files in chrome/browser/ into a themes/ subdir. Rename (and resort) every #include. BUG=50548 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57375

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -112 lines) Patch
M chrome/browser/chromeos/frame/normal_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/background_gradient_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_controller.mm View 1 chunk +3 lines, -3 lines 1 comment Download
M chrome/browser/cocoa/bookmark_bar_toolbar_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/browser_frame_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller_private.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bubble_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/chrome_browser_window.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/download_item_cell.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/download_item_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/download_shelf_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/download_shelf_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/fullscreen_window.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/gradient_button_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/infobar_gradient_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/styled_text_field_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/tab_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/tab_strip_view.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/tab_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/ntp_resource_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/notifications/balloon_view_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/dragged_tab_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ntp_background_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile_impl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/themes/browser_theme_pack.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/themes/browser_theme_pack.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/themes/browser_theme_pack_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/themes/browser_theme_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/themes/browser_theme_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/themes/browser_theme_provider_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/themes/browser_theme_provider_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/themes/browser_theme_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_instructions_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/views/detachable_toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_frame_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/notifications/balloon_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/theme_background.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
go go gadget rename scripts http://codereview.chromium.org/3173043/diff/1/5 File chrome/browser/cocoa/bookmark_bar_folder_controller.mm (left): http://codereview.chromium.org/3173043/diff/1/5#oldcode5 chrome/browser/cocoa/bookmark_bar_folder_controller.mm:5: #import "chrome/browser/cocoa/bookmark_bar_folder_controller.h" Fixed this ...
10 years, 4 months ago (2010-08-24 23:42:49 UTC) #1
Elliot Glaysher
10 years, 4 months ago (2010-08-24 23:46:35 UTC) #2
Rubber Stamp.

On Tue, Aug 24, 2010 at 4:42 PM,  <evan@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> go go gadget rename scripts
>
>
> http://codereview.chromium.org/3173043/diff/1/5
> File chrome/browser/cocoa/bookmark_bar_folder_controller.mm (left):
>
> http://codereview.chromium.org/3173043/diff/1/5#oldcode5
> chrome/browser/cocoa/bookmark_bar_folder_controller.mm:5: #import
> "chrome/browser/cocoa/bookmark_bar_folder_controller.h"
> Fixed this one locally.
>
> Description:
> Move theme files in chrome/browser/ into a themes/ subdir.
>
> Rename (and resort) every #include.
>
> BUG=50548
> TEST=compiles
>
> Please review this at http://codereview.chromium.org/3173043/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M chrome/browser/chromeos/frame/normal_browser_frame_view.cc
>  M chrome/browser/cocoa/background_gradient_view.mm
>  M chrome/browser/cocoa/bookmark_bar_controller.mm
>  M chrome/browser/cocoa/bookmark_bar_folder_controller.mm
>  M chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
>  M chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
>  M chrome/browser/cocoa/bookmark_bar_view.mm
>  M chrome/browser/cocoa/browser_frame_view.mm
>  M chrome/browser/cocoa/browser_window_controller.mm
>  M chrome/browser/cocoa/browser_window_controller_private.mm
>  M chrome/browser/cocoa/bubble_view.mm
>  M chrome/browser/cocoa/chrome_browser_window.mm
>  M chrome/browser/cocoa/download_item_cell.mm
>  M chrome/browser/cocoa/download_item_controller.mm
>  M chrome/browser/cocoa/download_shelf_controller.mm
>  M chrome/browser/cocoa/download_shelf_view.mm
>  M chrome/browser/cocoa/fullscreen_window.mm
>  M chrome/browser/cocoa/gradient_button_cell.mm
>  M chrome/browser/cocoa/infobar_gradient_view.mm
>  M chrome/browser/cocoa/styled_text_field_cell.mm
>  M chrome/browser/cocoa/tab_controller.mm
>  M chrome/browser/cocoa/tab_strip_view.mm
>  M chrome/browser/cocoa/tab_view.mm
>  M chrome/browser/cocoa/toolbar_controller.mm
>  M chrome/browser/debugger/devtools_window.cc
>  M chrome/browser/dom_ui/dom_ui.cc
>  M chrome/browser/dom_ui/dom_ui_theme_source.cc
>  M chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
>  M chrome/browser/dom_ui/ntp_resource_cache.cc
>  M chrome/browser/extensions/extension_host.cc
>  M chrome/browser/extensions/theme_installed_infobar_delegate.cc
>  M chrome/browser/gtk/browser_toolbar_gtk.cc
>  M chrome/browser/gtk/browser_window_gtk.cc
>  M chrome/browser/gtk/gtk_theme_provider.h
>  M chrome/browser/gtk/notifications/balloon_view_gtk.cc
>  M chrome/browser/gtk/tabs/dragged_tab_gtk.cc
>  M chrome/browser/gtk/tabs/tab_strip_gtk.cc
>  M chrome/browser/ntp_background_util.cc
>  M chrome/browser/profile.cc
>  M chrome/browser/profile_impl.cc
>  M chrome/browser/sync/glue/theme_change_processor.cc
>  M chrome/browser/sync/glue/theme_model_associator.cc
>  A + chrome/browser/themes/browser_theme_pack.h
>  A + chrome/browser/themes/browser_theme_pack.cc
>  A + chrome/browser/themes/browser_theme_pack_unittest.cc
>  A + chrome/browser/themes/browser_theme_provider.h
>  A + chrome/browser/themes/browser_theme_provider.cc
>  A + chrome/browser/themes/browser_theme_provider_gtk.cc
>  A + chrome/browser/themes/browser_theme_provider_mac.mm
>  A + chrome/browser/themes/browser_theme_provider_unittest.cc
>  M chrome/browser/views/bookmark_bar_instructions_view.cc
>  M chrome/browser/views/bookmark_bar_view.cc
>  M chrome/browser/views/browser_actions_container.cc
>  M chrome/browser/views/detachable_toolbar_view.cc
>  M chrome/browser/views/download_item_view.cc
>  M chrome/browser/views/download_shelf_view.cc
>  M chrome/browser/views/find_bar_view.cc
>  M chrome/browser/views/frame/browser_frame_gtk.cc
>  M chrome/browser/views/frame/browser_frame_win.cc
>  M chrome/browser/views/frame/browser_view.cc
>  M chrome/browser/views/frame/glass_browser_frame_view.cc
>  M chrome/browser/views/frame/opaque_browser_frame_view.cc
>  M chrome/browser/views/notifications/balloon_view.cc
>  M chrome/browser/views/status_bubble_views.cc
>  M chrome/browser/views/tabs/tab.cc
>  M chrome/browser/views/tabs/tab_strip.cc
>  M chrome/browser/views/theme_background.cc
>  M chrome/browser/views/toolbar_view.cc
>  M chrome/chrome_browser.gypi
>  M chrome/chrome_tests.gypi
>  M chrome/test/testing_profile.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698