Issue 3173038: Enabling about:system page to select shown entries and to scroll to specific ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3173038: Enabling about:system page to select shown entries and to scroll to specific ... (Closed)

Created:
10 years, 4 months ago by tonibarzic

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews), DaveMoore, tbarzic, zel

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Enabling about:system page to select shown entries and to scroll to specific entry TEST=Open about:system. Table containing available system information is shown. Clicking on button Expand shows associated entry, and clicking on Collapse hides it. Initialy all entries are hidden. Clicking on Expand all / Collapse all shows / hides all entries. about:system/foo hides all entries but foo, and scrolls to it BUG=4973 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57288

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -43 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+25 lines, -1 line	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	3 chunks	+22 lines, -7 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/about_sys.html	View	5 chunks	+152 lines, -34 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zel

lgtm with a minor nit http://codereview.chromium.org/3173038/diff/1/5 File chrome/browser/resources/about_sys.html (right): http://codereview.chromium.org/3173038/diff/1/5#newcode234 chrome/browser/resources/about_sys.html:234: }) semicolon missing

10 years, 4 months ago (2010-08-24 04:29:56 UTC) #2

LGTM

Expand Messages | Collapse Messages