Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 3173033: Let use_accelerated_compositing be usable for both enabling and disabling compositing (Closed)

Created:
10 years, 4 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Let use_accelerated_compositing be usable for both enabling and disabling compositing. With this, Chromium can be built on 10.5 again with the following ~/.gyp/include.gypi: { 'variables': { 'build_ffmpegsumo': 0, 'use_system_ffmpeg': 0, 'disable_nacl': 1, 'enable_svg': 0, 'use_accelerated_compositing': 0, } } Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/features_override.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
This doesn't change the default, but now use_accelerated_compositing=0 turns the feature off, which brings the ...
10 years, 4 months ago (2010-08-20 06:43:48 UTC) #1
Ken Russell (switch to Gerrit)
10 years, 4 months ago (2010-08-20 07:05:53 UTC) #2
LGTM -- it seems a little weird that forcibly setting
use_accelerated_compositing=1 won't cause the code to be built on a new
platform, but at this point this is a reasonable default and change.

Powered by Google App Engine
This is Rietveld 408576698