chrome/test/mini_installer_test/chrome_mini_installer.cc - Issue 3172009: Cleanup Registry API: part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer_test/chrome_mini_installer.cc

Issue 3172009: Cleanup Registry API: part 3. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: chrome fixes Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/mini_installer_test/chrome_mini_installer.cc

diff --git a/chrome/test/mini_installer_test/chrome_mini_installer.cc b/chrome/test/mini_installer_test/chrome_mini_installer.cc

index 81e9460caad91bd9bd7f4a3215cc45adf07aae03..9be3a245f7834d2a81903019554d2ecaaba51e1b 100644

--- a/chrome/test/mini_installer_test/chrome_mini_installer.cc

+++ b/chrome/test/mini_installer_test/chrome_mini_installer.cc

@@ -506,7 +506,7 @@ std::wstring ChromeMiniInstaller::GetUninstallPath() {

bool ChromeMiniInstaller::GetChromeVersionFromRegistry(

std::wstring* build_key_value) {

BrowserDistribution* dist = BrowserDistribution::GetDistribution();

- RegKey key(GetRootRegistryKey(), dist->GetVersionKey().c_str());

+ RegKey key(GetRootRegistryKey(), dist->GetVersionKey().c_str(), KEY_READ);

if (!key.ReadValue(L"pv", build_key_value)) {

printf("registry key not found\n");

return false;

« no previous file with comments | « chrome/installer/util/shell_util.cc ('k') | chrome_frame/test/chrome_frame_test_utils.cc » ('j') | no next file with comments »