chrome/app/breakpad_win.cc - Issue 3172009: Cleanup Registry API: part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/breakpad_win.cc

Issue 3172009: Cleanup Registry API: part 3. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: chrome fixes Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/breakpad_win.cc

diff --git a/chrome/app/breakpad_win.cc b/chrome/app/breakpad_win.cc

index a21f5b50cb6c2a0dadc56ceb7302e8681b263e23..09f3db4ab5f9d76f683fe875565e834e8f7c566c 100644

--- a/chrome/app/breakpad_win.cc

+++ b/chrome/app/breakpad_win.cc

@@ -395,13 +395,13 @@ bool ShowRestartDialogIfCrashed(bool* exit_now) {

static bool MetricsReportingControlledByPolicy(bool* result) {

std::wstring key_name = UTF8ToWide(policy::key::kMetricsReportingEnabled);

DWORD value;

- RegKey hkcu_policy_key(HKEY_LOCAL_MACHINE, policy::kRegistrySubKey);

+ RegKey hkcu_policy_key(HKEY_LOCAL_MACHINE, policy::kRegistrySubKey, KEY_READ);

if (hkcu_policy_key.ReadValueDW(key_name.c_str(), &value)) {

*result = value != 0;

return true;

}

- RegKey hklm_policy_key(HKEY_CURRENT_USER, policy::kRegistrySubKey);

+ RegKey hklm_policy_key(HKEY_CURRENT_USER, policy::kRegistrySubKey, KEY_READ);

if (hklm_policy_key.ReadValueDW(key_name.c_str(), &value)) {

*result = value != 0;

return true;

« no previous file with comments | « base/win_util.cc ('k') | chrome/browser/extensions/extension_rlz_apitest.cc » ('j') | no next file with comments »