Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2939)

Unified Diff: bin/cbuildbot.py

Issue 3171032: Fix bug with git packages with no matching ebuild. (Closed) Base URL: http://git.chromium.org/git/crosutils.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cbuildbot.py
diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py
index aa3a1d851b04797e1be1d97d25add04baa35aad4..685443db7e3bfabc92677e7bc1fc226eee543d0d 100755
--- a/bin/cbuildbot.py
+++ b/bin/cbuildbot.py
@@ -199,9 +199,11 @@ def _ParseRevisionString(revision_string, repo_dictionary):
if len(revision_tuple) != 2:
print >> sys.stderr, 'Incorrectly formatted revision %s' % revision
repo_name = revision_tuple[0].replace('.git', '')
- # May be many corresponding packages to a given git repo e.g. kernel)
- for package in repo_dictionary[repo_name]:
- revisions[package] = revision_tuple[1]
+ # Might not have entry if no matching ebuild.
+ if repo_dictionary.has_key(repo_name):
+ # May be many corresponding packages to a given git repo e.g. kernel).
+ for package in repo_dictionary[repo_name]:
+ revisions[package] = revision_tuple[1]
return revisions.items()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698