Change search engine dialog image to be transparent, and use this image flipp...

Change search engine dialog image to be transparent, and use this image flipped as the RTL dialog top.

BUG=none
TEST=search engine dialog looks fine in LTR and RTL modes


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57248

[Miranda Callahan, 2010-08-24 18:56:55]

Scott, could you take a look at the windows code (this is just the simple change
we discussed earlier), and Evan, this is FYI and in case you have any comments.

[Evan Stade, 2010-08-24 19:23:12]

cool thanks

[sky, 2010-08-24 19:45:33]

http://codereview.chromium.org/3171028/diff/5001/6004
File chrome/browser/views/first_run_search_engine_view.cc (right):

http://codereview.chromium.org/3171028/diff/5001/6004#newcode152
chrome/browser/views/first_run_search_engine_view.cc:152: height() -
background_image_->height());
is height() always > background_image_->height()?

http://codereview.chromium.org/3171028/diff/5001/6005
File chrome/browser/views/first_run_search_engine_view.h (right):

http://codereview.chromium.org/3171028/diff/5001/6005#newcode107
chrome/browser/views/first_run_search_engine_view.h:107: void Paint(gfx::Canvas*
canvas);
virtual

[Miranda Callahan, 2010-08-24 20:54:08]

Thanks for the review, please take another look.

http://codereview.chromium.org/3171028/diff/5001/6004
File chrome/browser/views/first_run_search_engine_view.cc (right):

http://codereview.chromium.org/3171028/diff/5001/6004#newcode152
chrome/browser/views/first_run_search_engine_view.cc:152: height() -
background_image_->height());
On 2010/08/24 19:45:33, sky wrote:
> is height() always > background_image_->height()?

Yes, unless something's gone horribly wrong.  Putting in a DCHECK.  The height
is always hardcoded in locale_settings.grd, and the size of the background image
is set to be less than half of that height.

http://codereview.chromium.org/3171028/diff/5001/6005
File chrome/browser/views/first_run_search_engine_view.h (right):

http://codereview.chromium.org/3171028/diff/5001/6005#newcode107
chrome/browser/views/first_run_search_engine_view.h:107: void Paint(gfx::Canvas*
canvas);
On 2010/08/24 19:45:33, sky wrote:
> virtual

Done.

[sky, 2010-08-24 21:00:15]

Views LGTM