Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 3171026: Disable the use of -s or --server with gcl upload. (Closed)

Created:
10 years, 4 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Disable the use of -s or --server with gcl upload. It contradicts the previous changes to enforce codereview.settings. TEST=new unit test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M gcl.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/gcl_unittest.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 4 months ago (2010-08-23 20:56:17 UTC) #1
bradn
10 years, 4 months ago (2010-08-24 00:15:01 UTC) #2
LGTM (good idea)

Powered by Google App Engine
This is Rietveld 408576698