Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9746)

Unified Diff: chrome/common/net/test_url_fetcher_factory.h

Issue 3171019: Reland r56483 - Monitor network change in GoogleURLTracker (Closed)
Patch Set: check Chrome Frame Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search_engines/template_url_model.cc ('k') | chrome/common/net/url_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/test_url_fetcher_factory.h
diff --git a/chrome/common/net/test_url_fetcher_factory.h b/chrome/common/net/test_url_fetcher_factory.h
index 3d8646677eb68140a94d4411f012dd6aed542df2..e48c0e0c52df5f52002cb783e94989ea8f2ad6fe 100644
--- a/chrome/common/net/test_url_fetcher_factory.h
+++ b/chrome/common/net/test_url_fetcher_factory.h
@@ -53,6 +53,13 @@ class TestURLFetcher : public URLFetcher {
// Returns the data uploaded on this URLFetcher.
const std::string& upload_data() const { return URLFetcher::upload_data(); }
+ // Overriden to do nothing. URLFetcher implementation add reference
+ // to request_context_getter in core_, but it might not be released
+ // because we wouldn't call Core::CancelURLRequest.
+ // Without this, we'll see leaks of URLRequestContext in test.
+ virtual void set_requeset_context(
+ URLRequestContextGetter* request_context_getter) {}
+
private:
const GURL original_url_;
« no previous file with comments | « chrome/browser/search_engines/template_url_model.cc ('k') | chrome/common/net/url_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698