Issue 3171015: Add flushing to gclient revert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3171015: Add flushing to gclient revert. (Closed)

Created:
10 years, 4 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
chase

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Add flushing to gclient revert. Otherwise, if someone flush svn:ignore in src/third_part by error and that causes a lot of files to be deleted, buildbot may hang while waiting for output. BUG=Previous behavior killed the win try slaves. TEST=smoke tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56541

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	gclient_scm.py	View		3 chunks	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

chase

10 years, 4 months ago (2010-08-18 16:59:57 UTC) #2

lgtm with nit

This is one of the Capture codepaths I mentioned.  Looks like fixing Capture to
flush would not fix this case, either, so this fix is doubleplusgood.

http://codereview.chromium.org/3171015/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/3171015/diff/1/2#newcode13
gclient_scm.py:13: import sys
nit: move above 'import time'

Expand Messages | Collapse Messages