Issue 3171001: Fix logic error in LateOverride().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3171001: Fix logic error in LateOverride(). (Closed)

Created:
10 years, 4 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Fix logic error in LateOverride(). It would modify self.parsed_url even when it's called for a From() keyword Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55574

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -12 lines)			Patch
	M	gclient.py	View		5 chunks	+26 lines, -12 lines	0 comments	Download
	M	tests/gclient_smoketest.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM