Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: remoting/host/session_manager_unittest.cc

Issue 3170049: Fix valgrind memory leak in session_manager_unittest.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/session_manager_unittest.cc
===================================================================
--- remoting/host/session_manager_unittest.cc (revision 57434)
+++ remoting/host/session_manager_unittest.cc (working copy)
@@ -33,10 +33,10 @@
encoder_ = new MockEncoder();
client_ = new MockClientConnection();
record_ = new SessionManager(&message_loop_,
- &message_loop_,
- &message_loop_,
- capturer_,
- encoder_);
+ &message_loop_,
+ &message_loop_,
+ capturer_,
+ encoder_);
}
scoped_refptr<SessionManager> record_;
@@ -68,18 +68,9 @@
Encoder::EncodingInProgress |
Encoder::EncodingEnded);
arg2->Run(msg, state);
+ delete arg2;
awong 2010/08/26 20:39:06 Stupid non-self-deleting callbacks.
}
-ACTION_P(AssignCaptureData, data) {
- arg0[0] = data[0];
- arg0[1] = data[1];
- arg0[2] = data[2];
-}
-
-ACTION_P(AssignDirtyRect, rects) {
- *arg0 = *rects;
-}
-
TEST_F(SessionManagerTest, OneRecordCycle) {
Init();
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698