Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 3170042: dom-ui options: Fix incorrect handling of undefined values in pref UI.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/pref_ui.js
===================================================================
--- chrome/browser/resources/options/pref_ui.js (revision 57240)
+++ chrome/browser/resources/options/pref_ui.js (working copy)
@@ -25,10 +25,10 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.checked = event.value['value'] ? event.value['value']
- : event.value;
- self.managed = event.value['managed'] ? event.value['managed']
- : false;
+ self.checked = event.value['value'] != undefined ?
+ event.value['value'] : event.value;
+ self.managed = event.value['managed'] != undefined ?
+ event.value['managed'] : false;
self.disabled = self.managed;
});
@@ -72,10 +72,10 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- var value = event.value['value'] ? event.value['value']
- : event.value;
- self.managed = event.value['managed'] ? event.value['managed']
- : false;
+ var value = event.value['value'] != undefined ?
+ event.value['value'] : event.value;
+ self.managed = event.value['managed'] != undefined ?
+ event.value['managed'] : false;
self.checked = String(value) == self.value;
self.disabled = self.managed;
});
@@ -132,10 +132,10 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.value = event.value['value'] ? event.value['value']
- : event.value;
- self.managed = event.value['managed'] ? event.value['managed']
- : false;
+ self.value = event.value['value'] != undefined ?
+ event.value['value'] : event.value;
+ self.managed = event.value['managed'] != undefined ?
+ event.value['managed'] : false;
self.disabled = self.managed;
});
@@ -215,10 +215,10 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- var value = event.value['value'] ? event.value['value']
- : event.value;
- self.managed = event.value['managed'] ? event.value['managed']
- : false;
+ var value = event.value['value'] != undefined ?
+ event.value['value'] : event.value;
+ self.managed = event.value['managed'] != undefined ?
+ event.value['managed'] : false;
self.disabled = self.managed;
for (var i = 0; i < self.options.length; i++) {
if (self.options[i].value == value) {
@@ -307,10 +307,10 @@
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
- self.value = event.value['value'] ? event.value['value']
- : event.value;
- self.managed = event.value['managed'] ? event.value['managed']
- : false;
+ self.value = event.value['value'] != undefined ?
+ event.value['value'] : event.value;
+ self.managed = event.value['managed'] != undefined ?
+ event.value['managed'] : false;
self.disabled = self.managed;
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698