dom-ui options: Fix incorrect handling of undefined values in pref UI....

chrome/browser/resources/options/pref_ui.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var Preferences = options.Preferences;
   /////////////////////////////////////////////////////////////////////////////
   // PrefCheckbox class:
 
   // Define a constructor that uses an input element as its underlying element.
   var PrefCheckbox = cr.ui.define('input');
 
   PrefCheckbox.prototype = {
     // Set up the prototype chain
     __proto__: HTMLInputElement.prototype,
 
     /**
      * Initialization function for the cr.ui framework.
      */
     decorate: function() {
       this.type = 'checkbox';
       var self = this;
 
       // Listen to pref changes.
       Preferences.getInstance().addEventListener(this.pref,
           function(event) {
-            self.checked = event.value['value'] ? event.value['value']
-                                                : event.value;
-            self.managed = event.value['managed'] ? event.value['managed']
-                                                  : false;
+            self.checked = event.value['value'] != undefined ?
+                event.value['value'] : event.value;
+            self.managed = event.value['managed'] != undefined ?
+                event.value['managed'] : false;
             self.disabled = self.managed;
           });
 
       // Listen to user events.
       this.addEventListener('click',
           function(e) {
             Preferences.setBooleanPref(self.pref, self.checked, self.metric);
           });
     }
   };
@@ skipping 23 matching lines @@
     /**
      * Initialization function for the cr.ui framework.
      */
     decorate: function() {
       this.type = 'radio';
       var self = this;
 
       // Listen to pref changes.
       Preferences.getInstance().addEventListener(this.pref,
           function(event) {
-            var value = event.value['value'] ? event.value['value']
-                                             : event.value;
-            self.managed = event.value['managed'] ? event.value['managed']
-                                                  : false;
+            var value = event.value['value'] != undefined ?
+                event.value['value'] : event.value;
+            self.managed = event.value['managed'] != undefined ?
+                event.value['managed'] : false;
             self.checked = String(value) == self.value;
             self.disabled = self.managed;
           });
 
       // Listen to user events.
       this.addEventListener('change',
           function(e) {
             if(self.value == 'true' || self.value == 'false') {
               Preferences.setBooleanPref(self.pref,
                   self.value == 'true', self.metric);
@@ skipping 36 matching lines @@
 
     /**
      * Initialization function for the cr.ui framework.
      */
     decorate: function() {
       var self = this;
 
       // Listen to pref changes.
       Preferences.getInstance().addEventListener(this.pref,
           function(event) {
-            self.value = event.value['value'] ? event.value['value']
-                                              : event.value;
-            self.managed = event.value['managed'] ? event.value['managed']
-                                                  : false;
+            self.value = event.value['value'] != undefined ?
+                event.value['value'] : event.value;
+            self.managed = event.value['managed'] != undefined ?
+                event.value['managed'] : false;
             self.disabled = self.managed;
           });
 
       // Listen to user events.
       this.addEventListener('change',
           function(e) {
             Preferences.setIntegerPref(self.pref, self.value, self.metric);
           });
     }
   };
@@ skipping 59 matching lines @@
     __proto__: HTMLSelectElement.prototype,
 
     /**
     * Initialization function for the cr.ui framework.
     */
     decorate: function() {
       var self = this;
       // Listen to pref changes.
       Preferences.getInstance().addEventListener(this.pref,
           function(event) {
-            var value = event.value['value'] ? event.value['value']
-                                             : event.value;
-            self.managed = event.value['managed'] ? event.value['managed']
-                                                  : false;
+            var value = event.value['value'] != undefined ?
+                event.value['value'] : event.value;
+            self.managed = event.value['managed'] != undefined ?
+                event.value['managed'] : false;
             self.disabled = self.managed;
             for (var i = 0; i < self.options.length; i++) {
               if (self.options[i].value == value) {
                 self.selectedIndex = i;
                 return;
               }
             }
             // Item not found, select first item.
             self.selectedIndex = 0;
           });
@@ skipping 68 matching lines @@
 
     /**
      * Initialization function for the cr.ui framework.
      */
     decorate: function() {
       var self = this;
 
       // Listen to pref changes.
       Preferences.getInstance().addEventListener(this.pref,
           function(event) {
-            self.value = event.value['value'] ? event.value['value']
-                                              : event.value;
-            self.managed = event.value['managed'] ? event.value['managed']
-                                                  : false;
+            self.value = event.value['value'] != undefined ?
+                event.value['value'] : event.value;
+            self.managed = event.value['managed'] != undefined ?
+                event.value['managed'] : false;
             self.disabled = self.managed;
           });
 
       // Listen to user events.
       this.addEventListener('change',
           function(e) {
             Preferences.setStringPref(self.pref, self.value, self.metric);
           });
 
       window.addEventListener('unload',
@@ skipping 22 matching lines @@
     PrefNumber: PrefNumber,
     PrefNumeric: PrefNumeric,
     PrefRadio: PrefRadio,
     PrefRange: PrefRange,
     PrefSelect: PrefSelect,
     PrefTextField: PrefTextField
   };
 
 });