Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 3170036: Remove the virtual declaration from a couple of non-virtual JumpTarget... (Closed)

Created:
10 years, 4 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Remove the virtual declaration from a couple of non-virtual JumpTarget methods to avoid compiler warnings with some gcc versions. Committed: http://code.google.com/p/v8/source/detail?r=5314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/jump-target-heavy.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
10 years, 4 months ago (2010-08-22 18:09:12 UTC) #1
Erik Corry
LGTM
10 years, 4 months ago (2010-08-23 07:04:24 UTC) #2
Erik Corry
10 years, 4 months ago (2010-08-23 07:06:25 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698