Remove dependency on X509Certificate::Cache behaviour when selecting a client certificate on Win

Remove dependency on X509Certificate::Cache behaviour when selecting a client certificate on Win

On OS X and Linux (cocoa/gtk), the original X509Certificate pointer supplied in SSLCertRequestInfo's client_certs is the one returned when a user selects a certificate. 

On Windows, a new X509Certificate is created from the selected certificate and returned, rather than the original X509Certificate. This translates to a dependency on X509Certificate::Cache to return the same certificate, which, while presently is true, is an implementation specific detail that should not be relied upon.

BUG=none
TEST=SSL client authentication continues to work on Windows

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57003

[Ryan Sleevi, 2010-08-15 07:38:49]

David,

  Since you last touched these, would you mind reviewing? Nothing major, and
matches what's being done in cocoa/ and gtk/. The DCHECK is to match the
NOTREACHED() in those files for when the original certificate can't be located
(which should never happen)

[davidben, 2010-08-16 17:43:07]

LGTM

http://codereview.chromium.org/3170019/diff/1/2
File chrome/browser/views/ssl_client_certificate_selector_win.cc (right):

http://codereview.chromium.org/3170019/diff/1/2#newcode29
chrome/browser/views/ssl_client_certificate_selector_win.cc:29:
net::X509Certificate* cert = NULL;
Nit: I guess while you're at it, this declaration can be moved to line 53 or so.

[wtc, 2010-08-17 23:43:45]

LGTM.

I agree we don't need to create a new X509Certificate object when we
already have an array of them as input.

http://codereview.chromium.org/3170019/diff/1/2
File chrome/browser/views/ssl_client_certificate_selector_win.cc (right):

http://codereview.chromium.org/3170019/diff/1/2#newcode59
chrome/browser/views/ssl_client_certificate_selector_win.cc:59: cert =
client_cert;
Add a 'break' statement here after you found a match.
Don't forget to add the curly braces.