Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/arm/codegen-arm.cc

Issue 3170014: ARM: Fix another bug in r5252... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/codegen-arm.cc
===================================================================
--- src/arm/codegen-arm.cc (revision 5262)
+++ src/arm/codegen-arm.cc (working copy)
@@ -4833,10 +4833,13 @@
// Loop through all the keys in the descriptor array. If one of these is the
// symbol valueOf the result is false.
Label entry, loop;
+ // The use of ip to store the valueOf symbol asumes that it is not otherwise
Erik Corry 2010/08/13 12:36:22 asumes -> assumes
+ // used in the loop below.
+ __ mov(ip, Operand(Factory::value_of_symbol()));
__ jmp(&entry);
__ bind(&loop);
- __ ldr(scratch2_, FieldMemOperand(map_result_, 0));
- __ cmp(scratch2_, Operand(Factory::value_of_symbol()));
+ __ ldr(scratch2_, MemOperand(map_result_, 0));
+ __ cmp(scratch2_, ip);
__ b(eq, &false_result);
__ add(map_result_, map_result_, Operand(kPointerSize));
__ bind(&entry);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698