Issue 3170014: ARM: Fix another bug in r5252...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3170014: ARM: Fix another bug in r5252... (Closed)

Created:
10 years, 4 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Fix another bug in r5252 Also hoist the load of the valueOf symbol out of the loop. Committed: http://code.google.com/p/v8/source/detail?r=5263

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/arm/codegen-arm.cc	View		1 chunk	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 4 months ago (2010-08-13 12:36:22 UTC) #2

LGTM

http://codereview.chromium.org/3170014/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/3170014/diff/1/2#newcode4836
src/arm/codegen-arm.cc:4836: // The use of ip to store the valueOf symbol asumes
that it is not otherwise
asumes -> assumes

Expand Messages | Collapse Messages