Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 3170004: Minor change to for-in... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2463 matching lines...) Expand 10 before | Expand all | Expand 10 after
2474 __ ldr(r1, frame_->ElementAt(4)); 2474 __ ldr(r1, frame_->ElementAt(4));
2475 __ ldr(r1, FieldMemOperand(r1, HeapObject::kMapOffset)); 2475 __ ldr(r1, FieldMemOperand(r1, HeapObject::kMapOffset));
2476 __ cmp(r1, Operand(r2)); 2476 __ cmp(r1, Operand(r2));
2477 end_del_check.Branch(eq); 2477 end_del_check.Branch(eq);
2478 2478
2479 // Convert the entry to a string (or null if it isn't a property anymore). 2479 // Convert the entry to a string (or null if it isn't a property anymore).
2480 __ ldr(r0, frame_->ElementAt(4)); // push enumerable 2480 __ ldr(r0, frame_->ElementAt(4)); // push enumerable
2481 frame_->EmitPush(r0); 2481 frame_->EmitPush(r0);
2482 frame_->EmitPush(r3); // push entry 2482 frame_->EmitPush(r3); // push entry
2483 frame_->InvokeBuiltin(Builtins::FILTER_KEY, CALL_JS, 2); 2483 frame_->InvokeBuiltin(Builtins::FILTER_KEY, CALL_JS, 2);
2484 __ mov(r3, Operand(r0)); 2484 __ mov(r3, Operand(r0), SetCC);
2485
2486 // If the property has been removed while iterating, we just skip it. 2485 // If the property has been removed while iterating, we just skip it.
2487 __ LoadRoot(ip, Heap::kNullValueRootIndex);
2488 __ cmp(r3, ip);
2489 node->continue_target()->Branch(eq); 2486 node->continue_target()->Branch(eq);
2490 2487
2491 end_del_check.Bind(); 2488 end_del_check.Bind();
2492 // Store the entry in the 'each' expression and take another spin in the 2489 // Store the entry in the 'each' expression and take another spin in the
2493 // loop. r3: i'th entry of the enum cache (or string there of) 2490 // loop. r3: i'th entry of the enum cache (or string there of)
2494 frame_->EmitPush(r3); // push entry 2491 frame_->EmitPush(r3); // push entry
2495 { Reference each(this, node->each()); 2492 { Reference each(this, node->each());
2496 if (!each.is_illegal()) { 2493 if (!each.is_illegal()) {
2497 if (each.size() > 0) { 2494 if (each.size() > 0) {
2498 __ ldr(r0, frame_->ElementAt(each.size())); 2495 __ ldr(r0, frame_->ElementAt(each.size()));
(...skipping 8937 matching lines...) Expand 10 before | Expand all | Expand 10 after
11436 __ bind(&string_add_runtime); 11433 __ bind(&string_add_runtime);
11437 __ TailCallRuntime(Runtime::kStringAdd, 2, 1); 11434 __ TailCallRuntime(Runtime::kStringAdd, 2, 1);
11438 } 11435 }
11439 11436
11440 11437
11441 #undef __ 11438 #undef __
11442 11439
11443 } } // namespace v8::internal 11440 } } // namespace v8::internal
11444 11441
11445 #endif // V8_TARGET_ARCH_ARM 11442 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698