Issue 3169041: Improve setup_dev_packages so that it can run incrementally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3169041: Improve setup_dev_packages so that it can run incrementally. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Improve setup_dev_packages so that it can run incrementally. BUG=none TEST=ran to install latest libchrome, etc. Change-Id: I7d48a77b1528f5fb4ea1ba5b7f52a9a248f71c84

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	setup_dev_packages	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 4 months ago (2010-08-24 19:15:13 UTC) #2

LGTM

On Tue, Aug 24, 2010 at 9:55 AM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> Improve setup_dev_packages so that it can run incrementally.
>
> BUG=none
> TEST=ran to install latest libchrome, etc.
>
> Change-Id: I7d48a77b1528f5fb4ea1ba5b7f52a9a248f71c84
>
> Please review this at http://codereview.chromium.org/3169041/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  M setup_dev_packages
>
>
> Index: setup_dev_packages
> diff --git a/setup_dev_packages b/setup_dev_packages
> index
>
f7f162c725e077a0d28ec1314b763b109cfcc6fa..a8e6a7ef4f30fe50de0958de366940bc44396612
> 100755
> --- a/setup_dev_packages
> +++ b/setup_dev_packages
> @@ -6,7 +6,7 @@
>
>  set -ex
>
> -sudo USE=-crash emerge -av1 \
> +sudo USE=-crash emerge -DNauv1 \
>   chromeos-base/libchrome \
>   chromeos-base/metrics \
>   dev-cpp/gmock \
>
>
>

Expand Messages | Collapse Messages