Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 3169031: Revert 56738 - Fix CheckFalseTest.CheckFails on Linux after my change to ui_t... (Closed)

Created:
10 years, 4 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 56738 - Fix CheckFalseTest.CheckFails on Linux after my change to ui_test. This makes PathService clear its cache after overriding a path. We have many paths depending on each other, so this is necessary to avoid inconsistencies. TEST=ui_tests in Release mode BUG=49838 Review URL: http://codereview.chromium.org/2805100 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -51 lines) Patch
M base/path_service.h View 2 chunks +3 lines, -1 line 0 comments Download
M base/path_service.cc View 7 chunks +13 lines, -32 lines 0 comments Download
M chrome/browser/profile_impl.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/common/logging_chrome_uitest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
10 years, 4 months ago (2010-08-19 23:17:31 UTC) #1
Paweł Hajdan Jr.
10 years, 4 months ago (2010-08-19 23:21:39 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698