Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/test/live_sync/profile_sync_service_test_harness.h

Issue 3169028: Adding debugging info for sync integration tests. (Closed)
Patch Set: Adding id_ member to class ProfileSyncServiceTestHarness. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/live_sync/live_sync_test.cc ('k') | chrome/test/live_sync/profile_sync_service_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/live_sync/profile_sync_service_test_harness.h
diff --git a/chrome/test/live_sync/profile_sync_service_test_harness.h b/chrome/test/live_sync/profile_sync_service_test_harness.h
index bb88e4c79331caed35bb8d59ed1e4c01f0394d21..3b32930a9b24353fe448ced313b310ee8e94170f 100644
--- a/chrome/test/live_sync/profile_sync_service_test_harness.h
+++ b/chrome/test/live_sync/profile_sync_service_test_harness.h
@@ -24,7 +24,7 @@ class Profile;
class ProfileSyncServiceTestHarness : public ProfileSyncServiceObserver {
public:
ProfileSyncServiceTestHarness(Profile* p, const std::string& username,
- const std::string& password);
+ const std::string& password, int id);
// Creates a ProfileSyncService for the profile passed at construction and
// enables sync. Returns true only after sync has been fully initialized and
@@ -108,11 +108,13 @@ class ProfileSyncServiceTestHarness : public ProfileSyncServiceObserver {
virtual bool AwaitStatusChangeWithTimeout(int timeout_seconds,
const std::string& reason);
- // Returns true if the service initialized correctly. Set
- // is_auth_retry to true when calling this method second time after
- // an autentication failure.
+ // Returns true if the service initialized correctly. Set is_auth_retry to
+ // true when calling this method second time after an authentication failure.
bool WaitForServiceInit(bool is_auth_retry);
+ // Logs message with relevant info about client's sync state (if available).
+ void LogClientInfo(std::string message);
+
WaitState wait_state_;
Profile* profile_;
@@ -138,6 +140,9 @@ class ProfileSyncServiceTestHarness : public ProfileSyncServiceObserver {
std::string username_;
std::string password_;
+ // Client ID, used for logging purposes.
+ int id_;
+
DISALLOW_COPY_AND_ASSIGN(ProfileSyncServiceTestHarness);
};
« no previous file with comments | « chrome/test/live_sync/live_sync_test.cc ('k') | chrome/test/live_sync/profile_sync_service_test_harness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698