Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 3169028: Adding debugging info for sync integration tests. (Closed)

Created:
10 years, 4 months ago by Raghu Simha
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Adding debugging info for sync integration tests. The sync integration test logs do not reveal when different sync events occur on the ProfileSyncServiceTestHarness objects. This checkin adds logging for sync events so that failures are easier to debug. BUG=52761 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56800

Patch Set 1 #

Patch Set 2 : Fixing whitespace. #

Patch Set 3 : Adding period. #

Patch Set 4 : Fixing call to GetLastSessionSnapshot(). #

Patch Set 5 : Adding id_ member to class ProfileSyncServiceTestHarness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -9 lines) Patch
M chrome/test/live_sync/live_sync_test.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/profile_sync_service_test_harness.h View 1 2 3 4 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/test/live_sync/profile_sync_service_test_harness.cc View 1 2 3 4 13 chunks +40 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
10 years, 4 months ago (2010-08-19 21:50:48 UTC) #1
tim (not reviewing)
10 years, 4 months ago (2010-08-20 00:35:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698