Issue 3167039: AU: Simplify the automatic update check code a little.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3167039: AU: Simplify the automatic update check code a little. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Simplify the automatic update check code a little. Moves automatic update checks into the UpdateAttempter class. This is in preparation for resolving 2394. BUG=2394 TEST=unit tests, gmerged on device Change-Id: I66ddf860cc7e19334187dc7f1892ead53fc936c6

Patch Set 1 #

Patch Set 2 : Moved to UpdateAttempter. Added timeout logging back in. #

Patch Set 3 : Rename to avoid confusion. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -40 lines)			Patch
M	main.cc	View	1 2	2 chunks	+1 line, -40 lines	0 comments	Download
M	update_attempter.h	View	2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	update_attempter.cc	View	2	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

I've made some changes and moved the scheduling code to UpdateAttempter. Also, I've put the ...

10 years, 4 months ago (2010-08-25 22:35:02 UTC) #2

LGTM

Expand Messages | Collapse Messages