Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/arm/debug-arm.cc

Issue 3167037: Fix a bug in the handling of debug break in CallIC... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/debug-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 // -- r1 : key 218 // -- r1 : key
219 // -- r2 : receiver 219 // -- r2 : receiver
220 // -- lr : return address 220 // -- lr : return address
221 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit()); 221 Generate_DebugBreakCallHelper(masm, r0.bit() | r1.bit() | r2.bit());
222 } 222 }
223 223
224 224
225 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) { 225 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) {
226 // Calling convention for IC call (from ic-arm.cc) 226 // Calling convention for IC call (from ic-arm.cc)
227 // ----------- S t a t e ------------- 227 // ----------- S t a t e -------------
228 // -- r0: number of arguments 228 // -- r2: name
229 // -- r1: receiver
230 // -- lr: return address
231 // ----------------------------------- 229 // -----------------------------------
232 // Register r1 contains an object that needs to be pushed on the expression 230 Generate_DebugBreakCallHelper(masm, r2.bit());
233 // stack of the fake JS frame. r0 is the actual number of arguments not
234 // encoded as a smi, therefore it cannot be on the expression stack of the
235 // fake JS frame as it can easily be an invalid pointer (e.g. 1). r0 will be
236 // pushed on the stack of the C frame and restored from there.
237 Generate_DebugBreakCallHelper(masm, r1.bit());
238 } 231 }
239 232
240 233
241 void Debug::GenerateConstructCallDebugBreak(MacroAssembler* masm) { 234 void Debug::GenerateConstructCallDebugBreak(MacroAssembler* masm) {
242 // In places other than IC call sites it is expected that r0 is TOS which 235 // In places other than IC call sites it is expected that r0 is TOS which
243 // is an object - this is not generally the case so this should be used with 236 // is an object - this is not generally the case so this should be used with
244 // care. 237 // care.
245 Generate_DebugBreakCallHelper(masm, r0.bit()); 238 Generate_DebugBreakCallHelper(masm, r0.bit());
246 } 239 }
247 240
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 290
298 #undef __ 291 #undef __
299 292
300 293
301 294
302 #endif // ENABLE_DEBUGGER_SUPPORT 295 #endif // ENABLE_DEBUGGER_SUPPORT
303 296
304 } } // namespace v8::internal 297 } } // namespace v8::internal
305 298
306 #endif // V8_TARGET_ARCH_ARM 299 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/debug-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698