Issue 3167037: Fix a bug in the handling of debug break in CallIC...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3167037: Fix a bug in the handling of debug break in CallIC... (Closed)

Created:
10 years, 4 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix a bug in the handling of debug break in CallIC The change of calling convention in the CallIC was not reflected in the debug break code. Without the change to the debug break code the added test crashed. Committed: http://code.google.com/p/v8/source/detail?r=5333

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -21 lines)			Patch
M	src/arm/debug-arm.cc	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/ia32/debug-ia32.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/x64/debug-x64.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1	3 chunks	+36 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

This is a candidate for merging to the 2.2 branch!

10 years, 4 months ago (2010-08-24 22:04:43 UTC) #1

Kasper Lund

10 years, 4 months ago (2010-08-25 05:42:56 UTC) #2

LGTM also for merging to the 2.2 branch.

http://codereview.chromium.org/3167037/diff/1/5
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/3167037/diff/1/5#newcode872
test/cctest/test-debug.cc:872: // Mark sweep (and perhaps compact).
Maybe update comment. It always compacts now.

http://codereview.chromium.org/3167037/diff/1/5#newcode1163
test/cctest/test-debug.cc:1163: // Run with breakpoint
Terminate comment with .

Expand Messages | Collapse Messages