Fix bug in ImportingData Overlay

Fix a bug in ImportingData Overlay which cause crash when importing data multiple times.
Fix the problem when force closing the tab while importing.

BUG=49095
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56933

[zel, 2010-08-20 01:23:00]

http://codereview.chromium.org/3167028/diff/3001/4001
File chrome/browser/dom_ui/import_data_handler.cc (right):

http://codereview.chromium.org/3167028/diff/3001/4001#newcode59
chrome/browser/dom_ui/import_data_handler.cc:59: "load", NewCallback(this,
&ImportDataHandler::Load));
"load" is bit too generic for me. can you rename this method to "loadImporter"
or something like that?

[sargrass, 2010-08-20 01:37:57]

http://codereview.chromium.org/3167028/diff/3001/4001
File chrome/browser/dom_ui/import_data_handler.cc (right):

http://codereview.chromium.org/3167028/diff/3001/4001#newcode59
chrome/browser/dom_ui/import_data_handler.cc:59: "load", NewCallback(this,
&ImportDataHandler::Load));
On 2010/08/20 01:23:00, zel wrote:
> "load" is bit too generic for me. can you rename this method to "loadImporter"
> or something like that?

Done.

[zel, 2010-08-20 01:41:34]

http://codereview.chromium.org/3167028/diff/3001/4001
File chrome/browser/dom_ui/import_data_handler.cc (right):

http://codereview.chromium.org/3167028/diff/3001/4001#newcode59
chrome/browser/dom_ui/import_data_handler.cc:59: "load", NewCallback(this,
&ImportDataHandler::Load));
On 2010/08/20 01:37:57, sargrass wrote:
> On 2010/08/20 01:23:00, zel wrote:
> > "load" is bit too generic for me. can you rename this method to
"loadImporter"
> > or something like that?
> 
> Done.

I still see "load" there? Did you upload your files?

[sargrass, 2010-08-20 01:47:20]

http://codereview.chromium.org/3167028/diff/3001/4001
File chrome/browser/dom_ui/import_data_handler.cc (right):

http://codereview.chromium.org/3167028/diff/3001/4001#newcode59
chrome/browser/dom_ui/import_data_handler.cc:59: "load", NewCallback(this,
&ImportDataHandler::Load));
On 2010/08/20 01:41:34, zel wrote:
> On 2010/08/20 01:37:57, sargrass wrote:
> > On 2010/08/20 01:23:00, zel wrote:
> > > "load" is bit too generic for me. can you rename this method to
> "loadImporter"
> > > or something like that?
> > 
> > Done.
> 
> I still see "load" there? Did you upload your files?

I think in the new patch set it changes.

[csilv, 2010-08-20 19:01:55]

http://codereview.chromium.org/3167028/diff/8001/4005
File chrome/browser/dom_ui/import_data_handler.cc (right):

http://codereview.chromium.org/3167028/diff/8001/4005#newcode59
chrome/browser/dom_ui/import_data_handler.cc:59: "load", NewCallback(this,
&ImportDataHandler::LoadImporter));
Same as what zel requested, please change the "load" to "loadImporter" for
consistency with the method.

http://codereview.chromium.org/3167028/diff/8001/4007
File chrome/browser/resources/options/import_data_overlay.js (right):

http://codereview.chromium.org/3167028/diff/8001/4007#newcode112
chrome/browser/resources/options/import_data_overlay.js:112:
ImportDataOverlay.load = function() {
ImportDataOverlay.load -> ImportDataOverlay.loadImporter

http://codereview.chromium.org/3167028/diff/8001/4007#newcode113
chrome/browser/resources/options/import_data_overlay.js:113:
chrome.send('load');
'load' -> 'loadImporter'

http://codereview.chromium.org/3167028/diff/8001/4008
File chrome/browser/resources/options/personal_options.js (right):

http://codereview.chromium.org/3167028/diff/8001/4008#newcode71
chrome/browser/resources/options/personal_options.js:71:
ImportDataOverlay.load();
load -> loadImporter

[sargrass, 2010-08-20 19:17:30]

http://codereview.chromium.org/3167028/diff/8001/4005
File chrome/browser/dom_ui/import_data_handler.cc (right):

http://codereview.chromium.org/3167028/diff/8001/4005#newcode59
chrome/browser/dom_ui/import_data_handler.cc:59: "load", NewCallback(this,
&ImportDataHandler::LoadImporter));
On 2010/08/20 19:01:55, csilv wrote:
> Same as what zel requested, please change the "load" to "loadImporter" for
> consistency with the method.

Done.

http://codereview.chromium.org/3167028/diff/8001/4007
File chrome/browser/resources/options/import_data_overlay.js (right):

http://codereview.chromium.org/3167028/diff/8001/4007#newcode112
chrome/browser/resources/options/import_data_overlay.js:112:
ImportDataOverlay.load = function() {
On 2010/08/20 19:01:55, csilv wrote:
> ImportDataOverlay.load -> ImportDataOverlay.loadImporter

Done.

http://codereview.chromium.org/3167028/diff/8001/4007#newcode113
chrome/browser/resources/options/import_data_overlay.js:113:
chrome.send('load');
On 2010/08/20 19:01:55, csilv wrote:
> 'load' -> 'loadImporter'

Done.

http://codereview.chromium.org/3167028/diff/8001/4008
File chrome/browser/resources/options/personal_options.js (right):

http://codereview.chromium.org/3167028/diff/8001/4008#newcode71
chrome/browser/resources/options/personal_options.js:71:
ImportDataOverlay.load();
On 2010/08/20 19:01:55, csilv wrote:
> load -> loadImporter

Done.

[csilv, 2010-08-20 19:41:13]

LGTM

[sargrass, 2010-08-20 19:43:31]

Thank you. And, can you help me look at my other cl?

On Fri, Aug 20, 2010 at 12:41 PM, <csilv@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/3167028/show
>