Issue 3167004: Add clear command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3167004: Add clear command. (Closed)

Created:
10 years, 4 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

Add clear command.

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	utility/tpmc.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

May I have a quickie review please? Someone can use this.

10 years, 4 months ago (2010-08-10 21:57:11 UTC) #1

Randall Spangler

10 years, 4 months ago (2010-08-10 21:59:42 UTC) #2

LGTM

http://codereview.chromium.org/3167004/diff/1/2
File utility/tpmc.c (right):

http://codereview.chromium.org/3167004/diff/1/2#newcode63
utility/tpmc.c:63: { "clear", "clr", "clear the TPM (needs PP)", TlclForceClear
},
TPM --> TPM owner

Expand Messages | Collapse Messages