When extension is blacklisted by admin policy, it should be removed if alread...

When extension is blacklisted by admin policy, it should be removed if already running.
(Attempt 2 at landing this, this time with changes to fix Enabledness unit test)

BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56987

[Finnur, 2010-08-20 11:50:23]

This is identical to the old changelist, except for:

Moved the ProfileDestroyed function into the .cc file and unregister the prefs
there.

Changed the Enabledness unit test to recreate the profile when recreating the
ExtensionsService (normally the profile does not outlast the ExtensionsService,
so it seems like the right thing to do besides fixing the PrefRegistration
duplication issue with the test).

http://codereview.chromium.org/3166023/diff/1/4
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/3166023/diff/1/4#newcode207
chrome/browser/extensions/extensions_service.cc:207: // We outlive the profile,
so we don't unregister these.
I have removed this comment (didn't upload just for that).

[Aaron Boodman, 2010-08-20 17:06:43]

lgtm otherwise

http://codereview.chromium.org/3166023/diff/1/4
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/3166023/diff/1/4#newcode800
chrome/browser/extensions/extensions_service.cc:800: void
ExtensionsService::ProfileDestroyed() {
Sorry for nit'ing, but you should change this method name (and the one in
ExtensionMessageService) to DestroyingProfile or something otherwise the access
of profile_ looks suspicious.

[Finnur, 2010-08-20 20:46:19]

Good idea. I also changed the the one in ExtensionMessageService, to be
consistent, uploaded and sent it for the try servers. I'll check in after it
goes green.