Issue 3166008: Add object-visiting.cc into GYP/XCode/MSVC project files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3166008: Add object-visiting.cc into GYP/XCode/MSVC project files. (Closed)

Created:
10 years, 4 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Add object-visiting.cc into GYP/XCode/MSVC project files. Committed: http://code.google.com/p/v8/source/detail?r=5248

Patch Set 1 #

Total comments: 4

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -0 lines)			Patch
M	tools/gyp/v8.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/v8.xcodeproj/project.pbxproj	View	5 chunks	+8 lines, -0 lines	4 comments	Download
M	tools/visual_studio/v8_base.vcproj	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tools/visual_studio/v8_base_arm.vcproj	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/visual_studio/v8_base_x64.vcproj	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 4 months ago (2010-08-11 15:14:20 UTC) #2

LGTM

http://codereview.chromium.org/3166008/diff/1/3
File tools/v8.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/3166008/diff/1/3#newcode252
tools/v8.xcodeproj/project.pbxproj:252: C2D1E9731212F2BC00187A52 /*
objects-visiting.cc in Sources */ = {isa = PBXBuildFile; fileRef =
C2D1E9711212F27B00187A52 /* objects-visiting.cc */; };
I only think you need to add this once.

http://codereview.chromium.org/3166008/diff/1/3#newcode733
tools/v8.xcodeproj/project.pbxproj:733: C2D1E9711212F27B00187A52 /*
objects-visiting.cc */,
Look out for exploding cigars!

http://codereview.chromium.org/3166008/diff/1/3#newcode1277
tools/v8.xcodeproj/project.pbxproj:1277: C2D1E9731212F2BC00187A52 /*
objects-visiting.cc in Sources */,
And here!

http://codereview.chromium.org/3166008/diff/1/3#newcode1401
tools/v8.xcodeproj/project.pbxproj:1401: C2D1E9741212F2CF00187A52 /*
objects-visiting.cc in Sources */,
And here!

Expand Messages | Collapse Messages