Issue 3165059: [gcc] Fix lea splitters for ILP32 data model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3165059: [gcc] Fix lea splitters for ILP32 data model (Closed)

Created:
10 years, 4 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
khim, khimg, pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@gitrw.chromium.org:9222/nacl-toolchain.git

Visibility:
Public.

Description

[gcc] Fix lea splitters for ILP32 data model This is similar to http://codereview.chromium.org/3187016 and several previous changes. Fixed lea splitters to disallow PIC symbol references where immediate operand is needed. Now all specs cpu2000 compile with -fPIC. Hope the process of making these fixes should converge soon - instructions affected are instructions used for 32-bit pointer arithmetics, namely variants of add, sub and lea.

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	gcc/gcc/config/i386/i386.md	View		7 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pasko-google - do not use

do you promise to commit this to SVN immediately after committing to GIT?

10 years, 4 months ago (2010-08-25 09:48:55 UTC) #2

LGTM

Don't forget to send SVN CL for review :-)

Expand Messages | Collapse Messages