Issue 3165053: Implement IDBTransaction::objectStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3165053: Implement IDBTransaction::objectStore (Closed)

Created:
10 years, 4 months ago by andreip3000

Modified:
9 years, 6 months ago

Reviewers:
jorlow

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Implement IDBTransaction::objectStore This depends on https://bugs.webkit.org/show_bug.cgi?id=44446 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57185

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -6 lines)			Patch
M	chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc	View	3 chunks	+17 lines, -0 lines	1 comment	Download
M	chrome/common/render_messages_internal.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	chrome/renderer/renderer_webidbdatabase_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_webidbtransaction_impl.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

andreip3000

We need IDBTransaction::objectsStore so we can couple object stores with transactions.

10 years, 4 months ago (2010-08-24 08:39:36 UTC) #1

jorlow

10 years, 4 months ago (2010-08-24 08:46:16 UTC) #2

LGTM

http://codereview.chromium.org/3165053/diff/1/2
File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/3165053/diff/1/2#newcode758
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:758:
IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_IDBTransactionObjectStore,
OnObjectStore)
>80

Expand Messages | Collapse Messages