Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 3165039: build: Make enable_localaccount.sh skip outdated packages. (Closed)

Created:
10 years, 4 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
http://src.chromium.org/git/crosutils.git
Visibility:
Public.

Description

build: Make enable_localaccount.sh skip outdated packages. This script would previously fail before getting to make.conf.user if it couldn't access either of pam_google and pam_offline. Per cmasone, these packages are outdated now and don't need to be updated. BUG=none TEST=ran the script Change-Id: I5278c73562e580bdc90866c25c6b079b10b5e708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M enable_localaccount.sh View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
10 years, 4 months ago (2010-08-20 00:59:31 UTC) #1
Chris Masone
10 years, 4 months ago (2010-08-20 01:00:44 UTC) #2
LGTM

thanks, dan

On Thu, Aug 19, 2010 at 5:59 PM, <derat@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> build: Make enable_localaccount.sh skip outdated packages.
>
> This script would previously fail before getting to
> make.conf.user if it couldn't access either of pam_google
> and pam_offline.  Per cmasone, these packages are outdated
> now and don't need to be updated.
>
> BUG=none
> TEST=ran the script
>
> Change-Id: I5278c73562e580bdc90866c25c6b079b10b5e708
>
> Please review this at http://codereview.chromium.org/3165039/show
>
> SVN Base: http://src.chromium.org/git/crosutils.git
>
> Affected files:
>  M enable_localaccount.sh
>
>
> Index: enable_localaccount.sh
> diff --git a/enable_localaccount.sh b/enable_localaccount.sh
> index
>
ea54b41af3cc510f5a6b4df58f2804d61ed9c6d4..3590d7adec6bb865714762c24b156cbc43515e8a
> 100755
> --- a/enable_localaccount.sh
> +++ b/enable_localaccount.sh
> @@ -14,29 +14,6 @@ fi
>  chroot_path=${2:-"../../chroot"}
>
>  echo "Enabling local account $1@gmail.com."
> -echo "Remove these files to disable:"
> -
> -for namespace in pam_google pam_offline
> -do
> -   file=../platform/$namespace/pam_localaccount.h
> -   [ "$namespace" = pam_google ] && namespace=chromeos_pam
> -
> -   echo $file
> -
> -   cat <<EOF > $file
> -// local username for Chrome OS pam
> -// This file is auto-generated by enable_localaccount.sh
> -
> -#ifndef CHROMEOS_PAM_LOCALACCOUNT_H_
> -#define CHROMEOS_PAM_LOCALACCOUNT_H_
> -
> -namespace $namespace {
> -const char kLocalAccount[] = "$1@gmail.com";
> -}
> -
> -#endif // CHROMEOS_PAM_LOCALACCOUNT_H_
> -EOF
> -done
>
>  # Add CHROMEOS_LOCAL_ACCOUNT var to /etc/make.conf.user
>  echo "Setting CHROMEOS_LOCAL_ACCOUNT in
> $chroot_path/etc/make.conf.user..."
>
>
>

Powered by Google App Engine
This is Rietveld 408576698