[IndexedDB] Add transaction coordinator.

Add transaction coordinator. Allow idle transactions to be aborted when their parent JS context finishes executing.

This change depends on the following WebKit bug:

https://bugs.webkit.org/show_bug.cgi?id=44101

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56862

[jorlow, 2010-08-17 14:36:04]

http://codereview.chromium.org/3165026/diff/1/2
File chrome/browser/in_process_webkit/indexed_db_callbacks.h (right):

http://codereview.chromium.org/3165026/diff/1/2#newcode141
chrome/browser/in_process_webkit/indexed_db_callbacks.h:141: :
dispatcher_host_(dispatcher_host), transaction_id_(transaction_id) { }
} on new line

http://codereview.chromium.org/3165026/diff/1/2#newcode150
chrome/browser/in_process_webkit/indexed_db_callbacks.h:150: }
newline

http://codereview.chromium.org/3165026/diff/1/3
File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/3165026/diff/1/3#newcode214
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:214:
WebVector<int32> pendingIDs(ids.size());
fancy?

http://codereview.chromium.org/3165026/diff/1/3#newcode217
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:217: }
no brackets

http://codereview.chromium.org/3165026/diff/1/3#newcode639
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:639:
IndexedDBDispatcherHost::TransactionDispatcherHost::~TransactionDispatcherHost()
{
>80

http://codereview.chromium.org/3165026/diff/1/4
File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h (right):

http://codereview.chromium.org/3165026/diff/1/4#newcode106
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h:106: void
OnTransaction(int32 idb_database_id, const std::vector<string16>& names,
>80

http://codereview.chromium.org/3165026/diff/1/4#newcode169
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h:169: // FIXME: add
the rest of the transaction methods.
TODO

http://codereview.chromium.org/3165026/diff/1/6
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/3165026/diff/1/6#newcode2284
chrome/common/render_messages_internal.h:2284:
IPC_SYNC_MESSAGE_CONTROL4_1(ViewHostMsg_IDBDatabaseTransaction,
Put a TODO in here to make this async.  The way we'll do it is by having a map
from renderer (chrome code) allocated ids to browser allocated ids (web core
code) in the dispatcher host.

http://codereview.chromium.org/3165026/diff/1/6#newcode2368
chrome/common/render_messages_internal.h:2368: int32 /* idb_object_store_id */)
new line after

http://codereview.chromium.org/3165026/diff/1/8
File chrome/renderer/indexed_db_dispatcher.h (right):

http://codereview.chromium.org/3165026/diff/1/8#newcode86
chrome/renderer/indexed_db_dispatcher.h:86:
IDMap<WebKit::WebIDBTransactionCallbacks, IDMapOwnPointer>
transaction_callbacks_;
>80

http://codereview.chromium.org/3165026/diff/1/8#newcode86
chrome/renderer/indexed_db_dispatcher.h:86:
IDMap<WebKit::WebIDBTransactionCallbacks, IDMapOwnPointer>
transaction_callbacks_;
pending_transaction_callbacks_

http://codereview.chromium.org/3165026/diff/1/9
File chrome/renderer/renderer_webidbdatabase_impl.cc (right):

http://codereview.chromium.org/3165026/diff/1/9#newcode73
chrome/renderer/renderer_webidbdatabase_impl.cc:73: WebKit::WebIDBTransaction*
RendererWebIDBDatabaseImpl::transaction(const WebDOMStringList& names,
>80

http://codereview.chromium.org/3165026/diff/1/9#newcode75
chrome/renderer/renderer_webidbdatabase_impl.cc:75: int transaction_id;
move this down

http://codereview.chromium.org/3165026/diff/1/9#newcode76
chrome/renderer/renderer_webidbdatabase_impl.cc:76: std::vector<string16>
object_stores(names.length());
template magic makes this easy?

http://codereview.chromium.org/3165026/diff/1/9#newcode82
chrome/renderer/renderer_webidbdatabase_impl.cc:82: idb_database_id_,
object_stores, mode, timeout, &transaction_id));
4 more spaces

http://codereview.chromium.org/3165026/diff/1/11
File chrome/renderer/renderer_webidbfactory_impl.cc (right):

http://codereview.chromium.org/3165026/diff/1/11#newcode39
chrome/renderer/renderer_webidbfactory_impl.cc:39: for (size_t i = 0; i <
pendingIDs.size(); ++i) {
magic?  where is it?

http://codereview.chromium.org/3165026/diff/1/11#newcode41
chrome/renderer/renderer_webidbfactory_impl.cc:41: }
no brackets

http://codereview.chromium.org/3165026/diff/1/12
File chrome/renderer/renderer_webidbfactory_impl.h (right):

http://codereview.chromium.org/3165026/diff/1/12#newcode31
chrome/renderer/renderer_webidbfactory_impl.h:31: virtual void
abortPendingTransactions(const WebKit::WebVector<int>& pendingIDs);
>80

http://codereview.chromium.org/3165026/diff/1/13
File chrome/renderer/renderer_webidbtransaction_impl.cc (right):

http://codereview.chromium.org/3165026/diff/1/13#newcode18
chrome/renderer/renderer_webidbtransaction_impl.cc:18:
RendererWebIDBTransactionImpl::RendererWebIDBTransactionImpl(int32
idb_transaction_id)
80

http://codereview.chromium.org/3165026/diff/1/13#newcode29
chrome/renderer/renderer_webidbtransaction_impl.cc:29: // FIXME: implement
tabing..todo

http://codereview.chromium.org/3165026/diff/1/13#newcode36
chrome/renderer/renderer_webidbtransaction_impl.cc:36: // FIXME: implement
todo

http://codereview.chromium.org/3165026/diff/1/13#newcode52
chrome/renderer/renderer_webidbtransaction_impl.cc:52: void
RendererWebIDBTransactionImpl::setCallbacks(WebIDBTransactionCallbacks*
callbacks)
80

http://codereview.chromium.org/3165026/diff/1/14
File chrome/renderer/renderer_webidbtransaction_impl.h (right):

http://codereview.chromium.org/3165026/diff/1/14#newcode23
chrome/renderer/renderer_webidbtransaction_impl.h:23: virtual int mode() const;
indentation

http://codereview.chromium.org/3165026/diff/1/14#newcode27
chrome/renderer/renderer_webidbtransaction_impl.h:27: virtual void
setCallbacks(WebKit::WebIDBTransactionCallbacks*);
newline

[andreip3000, 2010-08-19 12:58:41]

Thanks Jeremy, all comments addressed. Please have another look.

[jorlow, 2010-08-19 13:05:34]

LGTM

http://codereview.chromium.org/3165026/diff/13001/14002
File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/3165026/diff/13001/14002#newcode635
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:635:
IndexedDBDispatcherHost::TransactionDispatcherHost::
I've been told to do the following in such cases:

IndexedDBDispatcherHost::
TransactionDispatcherHost::~TransactionDispatcherHost() {
}

http://codereview.chromium.org/3165026/diff/13001/14005
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/3165026/diff/13001/14005#newcode2284
chrome/common/render_messages_internal.h:2284: // TODO: make this message async.
Caps M.  Maybe add a few more details since we already thought about how best to
do this and it might be a while before we bother to do it.