Allow allocation in FailedAccessCheckCallback to allow embedders to...

Allow allocation in FailedAccessCheckCallback to allow embedders to
for instance throw exceptions in case of failed access checks.


Committed: http://code.google.com/p/v8/source/detail?r=5257

[Søren Thygesen Gjesse, 2010-08-13 06:51:23]

LGTM

http://codereview.chromium.org/3165016/diff/1/5
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/3165016/diff/1/5#newcode11209
test/cctest/test-api.cc:11209: i::Heap::CollectAllGarbage(false);
Should this maybe be true to force compaction?

[Mads Ager (chromium), 2010-08-13 06:54:50]

http://codereview.chromium.org/3165016/diff/1/5
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/3165016/diff/1/5#newcode11209
test/cctest/test-api.cc:11209: i::Heap::CollectAllGarbage(false);
On 2010/08/13 06:51:23, Søren Gjesse wrote:
> Should this maybe be true to force compaction?

I see no harm in that and it would cause more movement in the heap and
potentially catch more bugs. Will do. :)