Refactor the tools/test.py script and related testcfg.py files....

Refactor the tools/test.py script and related testcfg.py files.

This makes it possible to run several variants of the tests (with different flags that is) by adding extra lists to the VARIANT_FLAGS list. In addition, there is a number of smaller refactorings. 



Committed: http://code.google.com/p/v8/source/detail?r=5329

[Kasper Lund, 2010-08-19 05:09:59]

LGTM. You may want to tweak the timeout settings on the build bots after this
change is live.

http://codereview.chromium.org/3164023/diff/1/5
File test/mjsunit/testcfg.py (right):

http://codereview.chromium.org/3164023/diff/1/5#newcode94
test/mjsunit/testcfg.py:94: if self.self_script and (not
result.UnexpectedOutput()):
Maybe there should be an option to always unlink even when getting unexpected
output? Maybe add a helper on the result class (HasPreciousOutput?) that uses
this flag and UnexpectedOutput() to compute whether or not we should throw the
temporary script file away (used in two places in the testcfg.py files).

http://codereview.chromium.org/3164023/diff/1/7
File test/sputnik/testcfg.py (right):

http://codereview.chromium.org/3164023/diff/1/7#newcode60
test/sputnik/testcfg.py:60: if not result.UnexpectedOutput():
self.tmpfile.Dispose()
result.HasPreciousOutput() instead of result.UnexpectedOutput() and add flag so
the build bots can always dispose the temporary files?

[Rico, 2010-08-24 07:51:30]

Added flag and HasPreciousOutput to TestOutput
Please take another look

http://codereview.chromium.org/3164023/diff/1/5
File test/mjsunit/testcfg.py (right):

http://codereview.chromium.org/3164023/diff/1/5#newcode94
test/mjsunit/testcfg.py:94: if self.self_script and (not
result.UnexpectedOutput()):
On 2010/08/19 05:09:59, Kasper Lund wrote:
> Maybe there should be an option to always unlink even when getting unexpected
> output? Maybe add a helper on the result class (HasPreciousOutput?) that uses
> this flag and UnexpectedOutput() to compute whether or not we should throw the
> temporary script file away (used in two places in the testcfg.py files).

Done.

http://codereview.chromium.org/3164023/diff/1/7
File test/sputnik/testcfg.py (right):

http://codereview.chromium.org/3164023/diff/1/7#newcode60
test/sputnik/testcfg.py:60: if not result.UnexpectedOutput():
self.tmpfile.Dispose()
On 2010/08/19 05:09:59, Kasper Lund wrote:
> result.HasPreciousOutput() instead of result.UnexpectedOutput() and add flag
so
> the build bots can always dispose the temporary files? 

Done.

[Kasper Lund, 2010-08-24 13:33:15]

LGTM.